Skip to content

Provide a central component to decide if an application is a Spring Boot app or not #326

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
3 tasks
fabapp2 opened this issue Aug 15, 2022 · 0 comments
Closed
3 tasks
Labels

Comments

@fabapp2
Copy link
Contributor

fabapp2 commented Aug 15, 2022

labels: ["to_archive"]

What needs to be done

Some Actions and Recipes need to know if a module defines a Spring Boot application (deployable).
Currently, we assume all Spring Boot applications have a @SpringBootApplication annotated class.

Why it needs to be done

There are more ways to declare a Spring Boot application than adding a @SpringBootApplication annotation.
These would currently not be understood as Spring Boot applications.

What needs to be done

  • Create a list of all possibilities to define Spring Boot application
  • Implement a centralized component that has this knowledge
  • Refactor existing code (like AddSpringBootApplicationPropertiesAction to use this component)

Additional Information

#225

From the team:

A class with a main method and SpringApplication or SpringApplicationBuilder would be a pretty good sign, but there are lots of ways users could structure their apps. The could have a class with main that delegates off to a different class. If you're able to poke at Maven you might be able to look for the repackage goal being used (as long as skip isn't set). Then again, devs might be using the shade plugin so that wouldn't work always either.

@fabapp2 fabapp2 closed this as not planned Won't fix, can't repro, duplicate, stale Aug 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant