Skip to content

Rework condition for JSON-B recipe #328

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
fabapp2 opened this issue Aug 16, 2022 · 2 comments
Closed

Rework condition for JSON-B recipe #328

fabapp2 opened this issue Aug 16, 2022 · 2 comments
Labels
3.0.0 Spring Boot 3.0.0 type: enhancement New feature or request
Milestone
v0.12.0

Comments

@fabapp2
Copy link
Contributor

fabapp2 commented Aug 16, 2022 •
edited
Loading

The condition needs to check if Spring Boot version is 2.7 and if any JSON-B dependency exists.
@fabapp2 fabapp2 added type: enhancement New feature or request 3.0.0 Spring Boot 3.0.0 labels Aug 16, 2022
@fabapp2 fabapp2 changed the title Rework condition for Micrometer binder package Rework condition for JSON-B recipe Aug 16, 2022
@sanagaraj-pivotal
Copy link
Contributor

sanagaraj-pivotal commented Aug 18, 2022 •
edited
Loading

I think we do not need this feature because this file: boot-2.7-3.0-dependency-version-update.yaml has already a root level condition to make sure the spring boot project is 2.7.+ and hence we do not need a separate condition for JSON-B recipe

@fabapp2
Copy link
Contributor Author

fabapp2 commented Aug 18, 2022

righty, works for me. Closing the issue now.

@fabapp2 fabapp2 closed this as completed Aug 18, 2022
@fabapp2 fabapp2 added this to the v0.12.0 milestone Sep 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
3.0.0 Spring Boot 3.0.0 type: enhancement New feature or request
Projects
None yet
Milestone
v0.12.0
Development

No branches or pull requests
2 participants
@fabapp2 @sanagaraj-pivotal