Skip to content

ApplicationModules should recognize pom. types of jar and war as potential application module #403

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
fabapp2 opened this issue Sep 18, 2022 · 0 comments · Fixed by #405
Closed

ApplicationModules should recognize pom. types of jar and war as potential application module #403

fabapp2 opened this issue Sep 18, 2022 · 0 comments · Fixed by #405
Labels
type: enhancement New feature or request
Milestone
v0.12.0

Comments

@fabapp2
Copy link
Contributor

fabapp2 commented Sep 18, 2022

What needs to be done

The check in getTopmostApplicationModules() should also allow war

Why it needs to be done

Deployable modules are often of type war.
@fabapp2 fabapp2 added type: bug Something isn't working type: enhancement New feature or request and removed type: bug Something isn't working labels Sep 18, 2022
@fabapp2 fabapp2 linked a pull request Sep 18, 2022 that will close this issue
ApplicationModules recognizes war and jar as application module #405
Merged
@fabapp2 fabapp2 mentioned this issue Sep 18, 2022
Merged
@fabapp2 fabapp2 added this to the v0.12.0 milestone Sep 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
type: enhancement New feature or request
Projects
None yet
Milestone
v0.12.0
1 participant
@fabapp2