Skip to content

Provide a Maven pom cache for local Maven repository #759

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
fabapp2 opened this issue Apr 24, 2023 · 1 comment
Closed

Provide a Maven pom cache for local Maven repository #759

fabapp2 opened this issue Apr 24, 2023 · 1 comment
Assignees
Labels
in: sbm-core type: enhancement New feature or request wontfix This will not be worked on
Milestone

Comments

@fabapp2
Copy link
Contributor

fabapp2 commented Apr 24, 2023

What needs to be done

A new MavenPomCache implementation should be provided that uses the local Maven repository to cache downloaded pom files.

Why it needs to be done

Currently, only RocksDBMavenPomCache and InMemoryPomCache exist.
With RocksDBMavenPomCache we faced problems with locked dirs every now and then.
With the ´InMemoryMvenPomCache` poms are not persisted and bandwidth is wasted and Internet connection required when running a build.

Acceptance Criteria

Additional Information

The MavenPomCache API expects a Pom which is the model representation of a pom file but can't be serialized to a text file.

@fabapp2 fabapp2 added type: enhancement New feature or request in: sbm-core labels Apr 24, 2023
@fabapp2 fabapp2 added this to the v0.15.0 milestone Apr 24, 2023
@fabapp2 fabapp2 self-assigned this Apr 24, 2023
@fabapp2
Copy link
Contributor Author

fabapp2 commented Apr 25, 2023

  • The MavenPomDownloader uses a MavenPomCache to store and retrieve pom files. Two implementations currently exist: InMemoryMavenPomCache and RocksDbMavenPomCache.
  • Providing a custom implementation to serialize Pom objects provided to the cache to the local Maven repository requires full de-/serialiation of Pom to pom file and vice versa
  • The pom files written to the local Maven repository must be readable by Maven

Because Poms can contain more information (e.g. repository.username and repository.password) than a pom file can hold (xsd) it is not possible to implement this issue at the moment.

@fabapp2 fabapp2 closed this as completed Apr 25, 2023
@fabapp2 fabapp2 added the wontfix This will not be worked on label Apr 25, 2023
@fabapp2 fabapp2 linked a pull request Apr 25, 2023 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
in: sbm-core type: enhancement New feature or request wontfix This will not be worked on
Projects
None yet
1 participant