Skip to content

Allow externally defined KoFu DSLs #253

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
0n3z opened this issue Oct 22, 2019 · 2 comments
Closed

Allow externally defined KoFu DSLs #253

0n3z opened this issue Oct 22, 2019 · 2 comments
Assignees
Labels
type: bug A general bug
Milestone

Comments

@0n3z
Copy link

0n3z commented Oct 22, 2019

AbstractDsl initialize() is marked as internal. This prevents external sub classes to work properly. If the constraint is relaxed, it would allow external projects to provide their own applicative DSLs or side projects to add featured DSLs enabling fast community driven enrichment.

@sdeleuze sdeleuze self-assigned this Apr 8, 2020
@sdeleuze
Copy link
Collaborator

sdeleuze commented Apr 8, 2020

Good point, I will change that as part of 0.3.

@sdeleuze sdeleuze added this to the 0.3.0 milestone May 27, 2020
@sdeleuze sdeleuze changed the title Allow external defined DSLs Allow external defined KoFu DSLs May 27, 2020
@sdeleuze sdeleuze changed the title Allow external defined KoFu DSLs Allow externally defined KoFu DSLs May 27, 2020
@sdeleuze
Copy link
Collaborator

I will then rollback #218 and make it public since protected does not allow the DSLs to initialize each others. Maybe #275 will allow extensibility while not exposing such "internal" method on the public API cc @poutsma.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: bug A general bug
Projects
None yet
Development

No branches or pull requests

2 participants