Skip to content

Commit eb97e12

Browse files
committed
Rename OidcProviderMetadataClaimAccessor.getJwksUri() -> getJwkSetUri()
Issue gh-143
1 parent ab591dc commit eb97e12

File tree

3 files changed

+7
-7
lines changed

3 files changed

+7
-7
lines changed

oauth2-authorization-server/src/main/java/org/springframework/security/oauth2/core/oidc/OidcProviderMetadataClaimAccessor.java

+1-1
Original file line numberDiff line numberDiff line change
@@ -75,7 +75,7 @@ default List<String> getTokenEndpointAuthenticationMethods() {
7575
*
7676
* @return the {@code URL} of the JSON Web Key Set
7777
*/
78-
default URL getJwksUri() {
78+
default URL getJwkSetUri() {
7979
return getClaimAsURL(OidcProviderMetadataClaimNames.JWKS_URI);
8080
}
8181

oauth2-authorization-server/src/test/java/org/springframework/security/oauth2/core/oidc/OidcProviderConfigurationTests.java

+4-4
Original file line numberDiff line numberDiff line change
@@ -62,7 +62,7 @@ public void buildWhenAllRequiredClaimsAndAdditionalClaimsThenCreated() {
6262
assertThat(providerConfiguration.getIssuer()).isEqualTo(url("https://example.com/issuer1"));
6363
assertThat(providerConfiguration.getAuthorizationEndpoint()).isEqualTo(url("https://example.com/issuer1/oauth2/authorize"));
6464
assertThat(providerConfiguration.getTokenEndpoint()).isEqualTo(url("https://example.com/issuer1/oauth2/token"));
65-
assertThat(providerConfiguration.getJwksUri()).isEqualTo(url("https://example.com/issuer1/oauth2/jwks"));
65+
assertThat(providerConfiguration.getJwkSetUri()).isEqualTo(url("https://example.com/issuer1/oauth2/jwks"));
6666
assertThat(providerConfiguration.getScopes()).containsExactly("openid");
6767
assertThat(providerConfiguration.getResponseTypes()).containsExactly("code");
6868
assertThat(providerConfiguration.getGrantTypes()).containsExactlyInAnyOrder("authorization_code", "client_credentials");
@@ -86,7 +86,7 @@ public void buildWhenOnlyRequiredClaimsThenCreated() {
8686
assertThat(providerConfiguration.getIssuer()).isEqualTo(url("https://example.com/issuer1"));
8787
assertThat(providerConfiguration.getAuthorizationEndpoint()).isEqualTo(url("https://example.com/issuer1/oauth2/authorize"));
8888
assertThat(providerConfiguration.getTokenEndpoint()).isEqualTo(url("https://example.com/issuer1/oauth2/token"));
89-
assertThat(providerConfiguration.getJwksUri()).isEqualTo(url("https://example.com/issuer1/oauth2/jwks"));
89+
assertThat(providerConfiguration.getJwkSetUri()).isEqualTo(url("https://example.com/issuer1/oauth2/jwks"));
9090
assertThat(providerConfiguration.getScopes()).containsExactly("openid");
9191
assertThat(providerConfiguration.getResponseTypes()).containsExactly("code");
9292
assertThat(providerConfiguration.getGrantTypes()).isNull();
@@ -111,7 +111,7 @@ public void buildWhenClaimsProvidedThenCreated() {
111111
assertThat(providerConfiguration.getIssuer()).isEqualTo(url("https://example.com/issuer1"));
112112
assertThat(providerConfiguration.getAuthorizationEndpoint()).isEqualTo(url("https://example.com/issuer1/oauth2/authorize"));
113113
assertThat(providerConfiguration.getTokenEndpoint()).isEqualTo(url("https://example.com/issuer1/oauth2/token"));
114-
assertThat(providerConfiguration.getJwksUri()).isEqualTo(url("https://example.com/issuer1/oauth2/jwks"));
114+
assertThat(providerConfiguration.getJwkSetUri()).isEqualTo(url("https://example.com/issuer1/oauth2/jwks"));
115115
assertThat(providerConfiguration.getScopes()).containsExactly("openid");
116116
assertThat(providerConfiguration.getResponseTypes()).containsExactly("code");
117117
assertThat(providerConfiguration.getGrantTypes()).isNull();
@@ -137,7 +137,7 @@ public void buildWhenClaimsProvidedWithUrlsThenCreated() {
137137
assertThat(providerConfiguration.getIssuer()).isEqualTo(url("https://example.com/issuer1"));
138138
assertThat(providerConfiguration.getAuthorizationEndpoint()).isEqualTo(url("https://example.com/issuer1/oauth2/authorize"));
139139
assertThat(providerConfiguration.getTokenEndpoint()).isEqualTo(url("https://example.com/issuer1/oauth2/token"));
140-
assertThat(providerConfiguration.getJwksUri()).isEqualTo(url("https://example.com/issuer1/oauth2/jwks"));
140+
assertThat(providerConfiguration.getJwkSetUri()).isEqualTo(url("https://example.com/issuer1/oauth2/jwks"));
141141
assertThat(providerConfiguration.getScopes()).containsExactly("openid");
142142
assertThat(providerConfiguration.getResponseTypes()).containsExactly("code");
143143
assertThat(providerConfiguration.getGrantTypes()).isNull();

oauth2-authorization-server/src/test/java/org/springframework/security/oauth2/core/oidc/http/converter/OidcProviderConfigurationHttpMessageConverterTests.java

+2-2
Original file line numberDiff line numberDiff line change
@@ -75,7 +75,7 @@ public void readInternalWhenRequiredParametersThenSuccess() throws Exception {
7575
assertThat(providerConfiguration.getIssuer()).isEqualTo(new URL("https://example.com/issuer1"));
7676
assertThat(providerConfiguration.getAuthorizationEndpoint()).isEqualTo(new URL("https://example.com/issuer1/oauth2/authorize"));
7777
assertThat(providerConfiguration.getTokenEndpoint()).isEqualTo(new URL("https://example.com/issuer1/oauth2/token"));
78-
assertThat(providerConfiguration.getJwksUri()).isEqualTo(new URL("https://example.com/issuer1/oauth2/jwks"));
78+
assertThat(providerConfiguration.getJwkSetUri()).isEqualTo(new URL("https://example.com/issuer1/oauth2/jwks"));
7979
assertThat(providerConfiguration.getResponseTypes()).containsExactly("code");
8080
assertThat(providerConfiguration.getSubjectTypes()).containsExactly("public");
8181
assertThat(providerConfiguration.getScopes()).isNull();
@@ -107,7 +107,7 @@ public void readInternalWhenValidParametersThenSuccess() throws Exception {
107107
assertThat(providerConfiguration.getIssuer()).isEqualTo(new URL("https://example.com/issuer1"));
108108
assertThat(providerConfiguration.getAuthorizationEndpoint()).isEqualTo(new URL("https://example.com/issuer1/oauth2/authorize"));
109109
assertThat(providerConfiguration.getTokenEndpoint()).isEqualTo(new URL("https://example.com/issuer1/oauth2/token"));
110-
assertThat(providerConfiguration.getJwksUri()).isEqualTo(new URL("https://example.com/issuer1/oauth2/jwks"));
110+
assertThat(providerConfiguration.getJwkSetUri()).isEqualTo(new URL("https://example.com/issuer1/oauth2/jwks"));
111111
assertThat(providerConfiguration.getScopes()).containsExactly("openid");
112112
assertThat(providerConfiguration.getResponseTypes()).containsExactly("code");
113113
assertThat(providerConfiguration.getGrantTypes()).containsExactlyInAnyOrder("authorization_code", "client_credentials");

0 commit comments

Comments
 (0)