You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
But i still can set JobRepository when building Job or Step like this.
@BeanpublicJobtestJob(JobRepositoryjobRepository) {
returnnewJobBuilder("testJob", jobRepository)
.start(
newStepBuilder("testStep", jobRepository)
.tasklet((a, b) -> RepeatStatus.FINISHED, newResourcelessTransactionManager())
.repository(jobRepository) // this
.build()
)
.repository(jobRepository) // this
.build();
}
It looks redundant since it's already set in constructor. So, how about remove repository method in JobBuilderHelper and StepBuilderHelper? Maybe it's better to deprecate first and remove in 6.0.0
acktsap
changed the title
[Deprecate jobRepository method in JobBuilderHelper & StepBuilderHelper
Deprecate jobRepository method in JobBuilderHelper & StepBuilderHelper
Mar 15, 2023
As of 5.0.0, it's recommanded to use JobBuilder, StepBuilder with
JobRepository
like this.But i still can set
JobRepository
when buildingJob
orStep
like this.It looks redundant since it's already set in constructor. So, how about remove repository method in
JobBuilderHelper
andStepBuilderHelper
? Maybe it's better to deprecate first and remove in 6.0.0spring-batch/spring-batch-core/src/main/java/org/springframework/batch/core/job/builder/JobBuilderHelper.java
Lines 94 to 104 in 4513d78
spring-batch/spring-batch-core/src/main/java/org/springframework/batch/core/step/builder/StepBuilderHelper.java
Lines 69 to 72 in 4513d78
The text was updated successfully, but these errors were encountered: