Skip to content

Disable Docker-based tests when Docker is not available #4360

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
fmbenhassine opened this issue Apr 27, 2023 · 2 comments
Closed

Disable Docker-based tests when Docker is not available #4360

fmbenhassine opened this issue Apr 27, 2023 · 2 comments
Assignees
@sukanth
Labels
in: build status: first-timers-only Issues that we would like first-timers only to work on type: enhancement
Milestone
5.0.2

Comments

@fmbenhassine
Copy link
Contributor

Currently, a full build runs Docker-based (TestContainers) integration tests no matter if Docker is available on the platform or not. This leads to a build failure when Docker is not available. This behaviour can be improved by disabling Docker-based tests when Docker is not available.

The TestContainers library provides the attribute @TestContainers(disabledWithoutDocker = true) for that case. The goal of this issue is to add that attribute to all tests annotated with @TestContainers.

Contributions are welcome!
@fmbenhassine fmbenhassine added in: build type: enhancement status: first-timers-only Issues that we would like first-timers only to work on labels Apr 27, 2023
@baezzys baezzys mentioned this issue Apr 28, 2023
Closed
@sukanth
Copy link
Contributor

sukanth commented Apr 28, 2023

@fmbenhassine can you assign this to me ? i can take this one

@sukanth sukanth mentioned this issue May 8, 2023
Closed
@sukanth
Copy link
Contributor

sukanth commented May 8, 2023

@fmbenhassine Thank you for assigning it to me . here is the PR #4367

@fmbenhassine fmbenhassine added this to the 5.0.2 milestone May 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sukanth sukanth

Labels
in: build status: first-timers-only Issues that we would like first-timers only to work on type: enhancement
Projects
None yet
Milestone
5.0.2
Development

No branches or pull requests
2 participants
@fmbenhassine @sukanth