Skip to content

Commit 6c1962f

Browse files
committed
Fix handling of booleans that are actually strings
Closes gh-40686
1 parent 101b3a5 commit 6c1962f

File tree

3 files changed

+6
-6
lines changed

3 files changed

+6
-6
lines changed

.github/actions/build/action.yml

+3-3
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,7 @@ inputs:
1919
outputs:
2020
build-scan-url:
2121
description: 'The URL, if any, of the build scan produced by the build'
22-
value: ${{ (inputs.publish && steps.build-and-publish.outputs.build-scan-url) || steps.build.outputs.build-scan-url }}
22+
value: ${{ (inputs.publish == 'true' && steps.build-and-publish.outputs.build-scan-url) || steps.build.outputs.build-scan-url }}
2323
version:
2424
description: 'The version that was built'
2525
value: ${{ steps.read-version.outputs.version }}
@@ -33,14 +33,14 @@ runs:
3333
java-toolchain: ${{ inputs.java-toolchain }}
3434
- name: Build
3535
id: build
36-
if: ${{ !inputs.publish }}
36+
if: ${{ inputs.publish == 'false' }}
3737
shell: bash
3838
env:
3939
DEVELOCITY_ACCESS_KEY: ${{ inputs.develocity-access-key }}
4040
run: ./gradlew build
4141
- name: Build and Publish
4242
id: build-and-publish
43-
if: ${{ inputs.publish }}
43+
if: ${{ inputs.publish == 'true' }}
4444
shell: bash
4545
env:
4646
DEVELOCITY_ACCESS_KEY: ${{ inputs.develocity-access-key }}

.github/actions/prepare-gradle-build/action.yml

+2-2
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,7 @@ runs:
1818
distribution: 'liberica'
1919
java-version: |
2020
${{ inputs.java-version }}
21-
${{ inputs.java-toolchain && '17' || '' }}
21+
${{ inputs.java-toolchain == 'true' && '17' || '' }}
2222
- name: Set Up Gradle
2323
uses: gradle/actions/setup-gradle@db19848a5fa7950289d3668fb053140cf3028d43 # v3.3.2
2424
with:
@@ -31,7 +31,7 @@ runs:
3131
echo 'systemProp.org.gradle.internal.launcher.welcomeMessageEnabled=false' >> $HOME/.gradle/gradle.properties
3232
echo 'org.gradle.daemon=false' >> $HOME/.gradle/gradle.properties
3333
- name: Configure Toolchain Properties
34-
if: ${{ inputs.java-toolchain }}
34+
if: ${{ inputs.java-toolchain == 'true' }}
3535
shell: bash
3636
run: |
3737
echo toolchainVersion=${{ inputs.java-version }} >> $HOME/.gradle/gradle.properties

.github/actions/publish-to-sdkman/action.yml

+1-1
Original file line numberDiff line numberDiff line change
@@ -27,7 +27,7 @@ runs:
2727
-d '{"candidate": "springboot", "version": "${{ inputs.spring-boot-version }}", "url": "${{ format('https://repo.maven.apache.org/maven2/org/springframework/boot/spring-boot-cli/{0}/spring-boot-cli-{0}-bin.zip', inputs.spring-boot-version) }}"}' \
2828
https://vendors.sdkman.io/release
2929
- shell: bash
30-
if: ${{ inputs.make-default }}
30+
if: ${{ inputs.make-default == 'true' }}
3131
run: >
3232
curl -X POST \
3333
-H "Consumer-Key: ${{ inputs.sdkman-consumer-key }}" \

0 commit comments

Comments
 (0)