Skip to content

Commit 71c9643

Browse files
committed
Merge pull request #43879 from izeye
* gh-43879: Polish Closes gh-43879
2 parents 34c8353 + 6c8d419 commit 71c9643

File tree

6 files changed

+11
-11
lines changed

6 files changed

+11
-11
lines changed

spring-boot-project/spring-boot-docker-compose/src/dockerTest/java/org/springframework/boot/docker/compose/service/connection/postgres/PostgresJdbcDockerComposeConnectionDetailsFactoryIntegrationTests.java

+2-2
Original file line numberDiff line numberDiff line change
@@ -63,15 +63,15 @@ private void checkDatabaseAccess(JdbcConnectionDetails connectionDetails) throws
6363
}
6464

6565
@SuppressWarnings("unchecked")
66-
private <T> T executeQuery(JdbcConnectionDetails connectionDetails, String sql, Class<T> result)
66+
private <T> T executeQuery(JdbcConnectionDetails connectionDetails, String sql, Class<T> resultClass)
6767
throws ClassNotFoundException {
6868
SimpleDriverDataSource dataSource = new SimpleDriverDataSource();
6969
dataSource.setUrl(connectionDetails.getJdbcUrl());
7070
dataSource.setUsername(connectionDetails.getUsername());
7171
dataSource.setPassword(connectionDetails.getPassword());
7272
dataSource.setDriverClass((Class<? extends Driver>) ClassUtils.forName(connectionDetails.getDriverClassName(),
7373
getClass().getClassLoader()));
74-
return new JdbcTemplate(dataSource).queryForObject(sql, result);
74+
return new JdbcTemplate(dataSource).queryForObject(sql, resultClass);
7575
}
7676

7777
}

spring-boot-project/spring-boot-docker-compose/src/dockerTest/java/org/springframework/boot/docker/compose/service/connection/postgres/PostgresR2dbcDockerComposeConnectionDetailsFactoryIntegrationTests.java

+2-2
Original file line numberDiff line numberDiff line change
@@ -63,11 +63,11 @@ private void checkDatabaseAccess(R2dbcConnectionDetails connectionDetails) {
6363
.isEqualTo(1);
6464
}
6565

66-
private <T> T executeQuery(R2dbcConnectionDetails connectionDetails, String sql, Class<T> result) {
66+
private <T> T executeQuery(R2dbcConnectionDetails connectionDetails, String sql, Class<T> resultClass) {
6767
ConnectionFactoryOptions connectionFactoryOptions = connectionDetails.getConnectionFactoryOptions();
6868
return DatabaseClient.create(ConnectionFactories.get(connectionFactoryOptions))
6969
.sql(sql)
70-
.mapValue(result)
70+
.mapValue(resultClass)
7171
.first()
7272
.block(Duration.ofSeconds(30));
7373
}

spring-boot-project/spring-boot-docker-compose/src/main/java/org/springframework/boot/docker/compose/core/DockerCliCommand.java

+1-1
Original file line numberDiff line numberDiff line change
@@ -241,7 +241,7 @@ enum Type {
241241
*/
242242
record ComposeVersion(int major, int minor) {
243243

244-
public static final ComposeVersion UNKNOWN = new ComposeVersion(0, 0);
244+
static final ComposeVersion UNKNOWN = new ComposeVersion(0, 0);
245245

246246
boolean isLessThan(int major, int minor) {
247247
return major() < major || major() == major && minor() < minor;

spring-boot-project/spring-boot-docs/src/docs/antora/modules/reference/pages/features/dev-services.adoc

+2-2
Original file line numberDiff line numberDiff line change
@@ -371,7 +371,7 @@ NOTE: Using a javadoc:org.springframework.boot.testcontainers.service.connection
371371

372372

373373
[[features.dev-services.testcontainers.at-development-time.importing-container-declarations]]
374-
==== Importing Testcontainer Declaration Classes
374+
==== Importing Testcontainers Declaration Classes
375375

376376
A common pattern when using Testcontainers is to declare javadoc:org.testcontainers.containers.Container[] instances as static fields.
377377
Often these fields are defined directly on the test class.
@@ -396,7 +396,7 @@ You can also add javadoc:org.springframework.test.context.DynamicPropertySource[
396396

397397
When using devtools, you can annotate beans and bean methods with javadoc:org.springframework.boot.devtools.restart.RestartScope[format=annotation].
398398
Such beans won't be recreated when the devtools restart the application.
399-
This is especially useful for Testcontainer javadoc:org.testcontainers.containers.Container[] beans, as they keep their state despite the application restart.
399+
This is especially useful for javadoc:org.testcontainers.containers.Container[] beans, as they keep their state despite the application restart.
400400

401401
include-code::MyContainersConfiguration[]
402402

spring-boot-project/spring-boot-testcontainers/src/main/java/org/springframework/boot/testcontainers/context/ImportTestcontainers.java

+1-1
Original file line numberDiff line numberDiff line change
@@ -28,7 +28,7 @@
2828
import org.springframework.context.annotation.Import;
2929

3030
/**
31-
* Imports idiomatic Testcontainer declaration classes into the Spring
31+
* Imports idiomatic Testcontainers declaration classes into the Spring
3232
* {@link ApplicationContext}. The following elements will be considered from the imported
3333
* classes:
3434
* <ul>

spring-boot-project/spring-boot/src/main/java/org/springframework/boot/logging/logback/DebugLogbackConfigurator.java

+3-3
Original file line numberDiff line numberDiff line change
@@ -45,13 +45,13 @@ public void conversionRule(String conversionWord, Class<? extends Converter> con
4545
}
4646

4747
@Override
48-
public void appender(String name, Appender<?> appender) {
48+
void appender(String name, Appender<?> appender) {
4949
info("Adding appender '" + appender + "' named '" + name + "'");
5050
super.appender(name, appender);
5151
}
5252

5353
@Override
54-
public void logger(String name, Level level, boolean additive, Appender<ILoggingEvent> appender) {
54+
void logger(String name, Level level, boolean additive, Appender<ILoggingEvent> appender) {
5555
info("Configuring logger '" + name + "' with level '" + level + "'. Additive: " + additive);
5656
if (appender != null) {
5757
info("Adding appender '" + appender + "' to logger '" + name + "'");
@@ -60,7 +60,7 @@ public void logger(String name, Level level, boolean additive, Appender<ILogging
6060
}
6161

6262
@Override
63-
public void start(LifeCycle lifeCycle) {
63+
void start(LifeCycle lifeCycle) {
6464
info("Starting '" + lifeCycle + "'");
6565
super.start(lifeCycle);
6666
}

0 commit comments

Comments
 (0)