Skip to content

Commit 8a425de

Browse files
izeyewilkinsona
authored andcommitted
Polish access modifiers for test classes
See gh-27736
1 parent 2baee89 commit 8a425de

File tree

42 files changed

+45
-46
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

42 files changed

+45
-46
lines changed

buildSrc/src/test/java/org/springframework/boot/build/artifactory/ArtifactoryRepositoryTests.java

+1-1
Original file line numberDiff line numberDiff line change
@@ -27,7 +27,7 @@
2727
*
2828
* @author Andy Wilkinson
2929
*/
30-
public class ArtifactoryRepositoryTests {
30+
class ArtifactoryRepositoryTests {
3131

3232
@Test
3333
void whenProjectVersionIsMilestoneThenRepositoryIsMilestone() {

buildSrc/src/test/java/org/springframework/boot/build/bom/BomPluginIntegrationTests.java

+2-2
Original file line numberDiff line numberDiff line change
@@ -38,14 +38,14 @@
3838
*
3939
* @author Andy Wilkinson
4040
*/
41-
public class BomPluginIntegrationTests {
41+
class BomPluginIntegrationTests {
4242

4343
private File projectDir;
4444

4545
private File buildFile;
4646

4747
@BeforeEach
48-
public void setup(@TempDir File projectDir) throws IOException {
48+
void setup(@TempDir File projectDir) throws IOException {
4949
this.projectDir = projectDir;
5050
this.buildFile = new File(this.projectDir, "build.gradle");
5151
}

buildSrc/src/test/java/org/springframework/boot/build/bom/bomr/version/ArtifactVersionDependencyVersionTests.java

+1-1
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,7 @@
2525
*
2626
* @author Andy Wilkinson
2727
*/
28-
public class ArtifactVersionDependencyVersionTests {
28+
class ArtifactVersionDependencyVersionTests {
2929

3030
@Test
3131
void parseWhenVersionIsNotAMavenVersionShouldReturnNull() {

buildSrc/src/test/java/org/springframework/boot/build/bom/bomr/version/CalendarVersionDependencyVersionTests.java

+1-1
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,7 @@
2525
*
2626
* @author Andy Wilkinson
2727
*/
28-
public class CalendarVersionDependencyVersionTests {
28+
class CalendarVersionDependencyVersionTests {
2929

3030
@Test
3131
void parseWhenVersionIsNotACalendarVersionShouldReturnNull() {

buildSrc/src/test/java/org/springframework/boot/build/bom/bomr/version/DependencyVersionTests.java

+1-1
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,7 @@
2525
*
2626
* @author Andy Wilkinson
2727
*/
28-
public class DependencyVersionTests {
28+
class DependencyVersionTests {
2929

3030
@Test
3131
void parseWhenValidMavenVersionShouldReturnArtifactVersionDependencyVersion() {

buildSrc/src/test/java/org/springframework/boot/build/bom/bomr/version/NumericQualifierDependencyVersionTests.java

+1-1
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,7 @@
2525
*
2626
* @author Andy Wilkinson
2727
*/
28-
public class NumericQualifierDependencyVersionTests {
28+
class NumericQualifierDependencyVersionTests {
2929

3030
@Test
3131
void isNewerThanOnVersionWithNumericQualifierWhenInputHasNoQualifierShouldReturnTrue() {

buildSrc/src/test/java/org/springframework/boot/build/bom/bomr/version/ReleaseTrainDependencyVersionTests.java

+1-1
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,7 @@
2525
*
2626
* @author Andy Wilkinson
2727
*/
28-
public class ReleaseTrainDependencyVersionTests {
28+
class ReleaseTrainDependencyVersionTests {
2929

3030
@Test
3131
void parsingOfANonReleaseTrainVersionReturnsNull() {

buildSrc/src/test/java/org/springframework/boot/build/log4j2/ReproduciblePluginsDatActionTests.java

+1-1
Original file line numberDiff line numberDiff line change
@@ -37,7 +37,7 @@
3737
*
3838
* @author Andy Wilkinson
3939
*/
40-
public class ReproduciblePluginsDatActionTests {
40+
class ReproduciblePluginsDatActionTests {
4141

4242
@Test
4343
void postProcessingOrdersCategoriesAndPlugins() throws IOException {

buildSrc/src/test/java/org/springframework/boot/build/mavenplugin/PluginXmlParserTests.java

+1-1
Original file line numberDiff line numberDiff line change
@@ -33,7 +33,7 @@
3333
* @author Andy Wilkinson
3434
* @author Mike Smithson
3535
*/
36-
public class PluginXmlParserTests {
36+
class PluginXmlParserTests {
3737

3838
private final PluginXmlParser parser = new PluginXmlParser();
3939

buildSrc/src/test/java/org/springframework/boot/build/optional/OptionalDependenciesPluginIntegrationTests.java

+3-3
Original file line numberDiff line numberDiff line change
@@ -34,14 +34,14 @@
3434
*
3535
* @author Andy Wilkinson
3636
*/
37-
public class OptionalDependenciesPluginIntegrationTests {
37+
class OptionalDependenciesPluginIntegrationTests {
3838

3939
private File projectDir;
4040

4141
private File buildFile;
4242

4343
@BeforeEach
44-
public void setup(@TempDir File projectDir) throws IOException {
44+
void setup(@TempDir File projectDir) throws IOException {
4545
this.projectDir = projectDir;
4646
this.buildFile = new File(this.projectDir, "build.gradle");
4747
}
@@ -80,7 +80,7 @@ void optionalDependenciesAreAddedToTestSourceSetsRuntimeClasspath() throws IOExc
8080
optionalDependenciesAreAddedToSourceSetClasspath("test", "runtimeClasspath");
8181
}
8282

83-
public void optionalDependenciesAreAddedToSourceSetClasspath(String sourceSet, String classpath)
83+
private void optionalDependenciesAreAddedToSourceSetClasspath(String sourceSet, String classpath)
8484
throws IOException {
8585
try (PrintWriter out = new PrintWriter(new FileWriter(this.buildFile))) {
8686
out.println("plugins {");

spring-boot-project/spring-boot-actuator/src/test/java/org/springframework/boot/actuate/endpoint/web/servlet/DefaultWebMvcTagsProviderTests.java

+1-1
Original file line numberDiff line numberDiff line change
@@ -39,7 +39,7 @@
3939
*
4040
* @author Andy Wilkinson
4141
*/
42-
public class DefaultWebMvcTagsProviderTests {
42+
class DefaultWebMvcTagsProviderTests {
4343

4444
@Test
4545
void whenTagsAreProvidedThenDefaultTagsArePresent() {

spring-boot-project/spring-boot-actuator/src/test/java/org/springframework/boot/actuate/metrics/http/OutcomeTests.java

+1-1
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,7 @@
2525
*
2626
* @author Andy Wilkinson
2727
*/
28-
public class OutcomeTests {
28+
class OutcomeTests {
2929

3030
@Test
3131
void outcomeForInformationalStatusIsInformational() {

spring-boot-project/spring-boot-actuator/src/test/java/org/springframework/boot/actuate/metrics/web/reactive/server/DefaultWebFluxTagsProviderTests.java

+1-1
Original file line numberDiff line numberDiff line change
@@ -37,7 +37,7 @@
3737
*
3838
* @author Andy Wilkinson
3939
*/
40-
public class DefaultWebFluxTagsProviderTests {
40+
class DefaultWebFluxTagsProviderTests {
4141

4242
@Test
4343
void whenTagsAreProvidedThenDefaultTagsArePresent() {

spring-boot-project/spring-boot-autoconfigure/src/test/java/org/springframework/boot/autoconfigure/AutoConfigurationPackagesTests.java

+1-1
Original file line numberDiff line numberDiff line change
@@ -35,7 +35,7 @@
3535
* @author Oliver Gierke
3636
*/
3737
@SuppressWarnings("resource")
38-
public class AutoConfigurationPackagesTests {
38+
class AutoConfigurationPackagesTests {
3939

4040
@Test
4141
void setAndGet() {

spring-boot-project/spring-boot-autoconfigure/src/test/java/org/springframework/boot/autoconfigure/context/LifecycleAutoConfigurationTests.java

+1-1
Original file line numberDiff line numberDiff line change
@@ -32,7 +32,7 @@
3232
*
3333
* @author Andy Wilkinson
3434
*/
35-
public class LifecycleAutoConfigurationTests {
35+
class LifecycleAutoConfigurationTests {
3636

3737
private final ApplicationContextRunner contextRunner = new ApplicationContextRunner()
3838
.withConfiguration(AutoConfigurations.of(LifecycleAutoConfiguration.class));

spring-boot-project/spring-boot-autoconfigure/src/test/java/org/springframework/boot/autoconfigure/data/elasticsearch/ReactiveElasticsearchRepositoriesAutoConfigurationTests.java

+1-1
Original file line numberDiff line numberDiff line change
@@ -45,7 +45,7 @@
4545
* @author Brian Clozel
4646
*/
4747
@Testcontainers(disabledWithoutDocker = true)
48-
public class ReactiveElasticsearchRepositoriesAutoConfigurationTests {
48+
class ReactiveElasticsearchRepositoriesAutoConfigurationTests {
4949

5050
@Container
5151
static ElasticsearchContainer elasticsearch = new ElasticsearchContainer(DockerImageNames.elasticsearch())

spring-boot-project/spring-boot-autoconfigure/src/test/java/org/springframework/boot/autoconfigure/data/elasticsearch/ReactiveElasticsearchRestClientAutoConfigurationTests.java

+1-1
Original file line numberDiff line numberDiff line change
@@ -45,7 +45,7 @@
4545
* @author Brian Clozel
4646
*/
4747
@Testcontainers(disabledWithoutDocker = true)
48-
public class ReactiveElasticsearchRestClientAutoConfigurationTests {
48+
class ReactiveElasticsearchRestClientAutoConfigurationTests {
4949

5050
@Container
5151
static ElasticsearchContainer elasticsearch = new ElasticsearchContainer(DockerImageNames.elasticsearch())

spring-boot-project/spring-boot-autoconfigure/src/test/java/org/springframework/boot/autoconfigure/data/neo4j/Neo4jReactiveRepositoriesAutoConfigurationTests.java

+1-1
Original file line numberDiff line numberDiff line change
@@ -40,7 +40,7 @@
4040
* @author Stephane Nicoll
4141
* @author Michael J. Simons
4242
*/
43-
public class Neo4jReactiveRepositoriesAutoConfigurationTests {
43+
class Neo4jReactiveRepositoriesAutoConfigurationTests {
4444

4545
private final ApplicationContextRunner contextRunner = new ApplicationContextRunner()
4646
.withUserConfiguration(MockedDriverConfiguration.class)

spring-boot-project/spring-boot-autoconfigure/src/test/java/org/springframework/boot/autoconfigure/data/neo4j/Neo4jRepositoriesAutoConfigurationIntegrationTests.java

+1-1
Original file line numberDiff line numberDiff line change
@@ -43,7 +43,7 @@
4343
*/
4444
@SpringBootTest
4545
@Testcontainers(disabledWithoutDocker = true)
46-
public class Neo4jRepositoriesAutoConfigurationIntegrationTests {
46+
class Neo4jRepositoriesAutoConfigurationIntegrationTests {
4747

4848
@Container
4949
private static final Neo4jContainer<?> neo4jServer = new Neo4jContainer<>(DockerImageNames.neo4j())

spring-boot-project/spring-boot-autoconfigure/src/test/java/org/springframework/boot/autoconfigure/freemarker/FreeMarkerAutoConfigurationTests.java

+1-1
Original file line numberDiff line numberDiff line change
@@ -37,7 +37,7 @@
3737
* @author Kazuki Shimizu
3838
*/
3939
@ExtendWith(OutputCaptureExtension.class)
40-
public class FreeMarkerAutoConfigurationTests {
40+
class FreeMarkerAutoConfigurationTests {
4141

4242
private final BuildOutput buildOutput = new BuildOutput(getClass());
4343

spring-boot-project/spring-boot-autoconfigure/src/test/java/org/springframework/boot/autoconfigure/packagestest/two/SecondConfiguration.java

+1-2
Original file line numberDiff line numberDiff line change
@@ -17,11 +17,10 @@
1717
package org.springframework.boot.autoconfigure.packagestest.two;
1818

1919
import org.springframework.boot.autoconfigure.AutoConfigurationPackage;
20-
import org.springframework.boot.autoconfigure.AutoConfigurationPackagesTests;
2120
import org.springframework.context.annotation.Configuration;
2221

2322
/**
24-
* Sample configuration used in {@link AutoConfigurationPackagesTests}.
23+
* Sample configuration used in {@code AutoConfigurationPackagesTests}.
2524
*
2625
* @author Oliver Gierke
2726
*/

spring-boot-project/spring-boot-test/src/test/java/org/springframework/boot/test/context/SpringBootTestWithActiveProfilesAndEnvironmentPropertyTests.java

+1-1
Original file line numberDiff line numberDiff line change
@@ -42,7 +42,7 @@
4242
@SpringBootTest
4343
@ActiveProfiles({ "test1", "test2" })
4444
@ContextConfiguration(loader = SpringBootTestWithActiveProfilesAndEnvironmentPropertyTests.Loader.class)
45-
public class SpringBootTestWithActiveProfilesAndEnvironmentPropertyTests {
45+
class SpringBootTestWithActiveProfilesAndEnvironmentPropertyTests {
4646

4747
@Autowired
4848
private Environment environment;

spring-boot-project/spring-boot-test/src/test/java/org/springframework/boot/test/context/SpringBootTestWithActiveProfilesAndSystemEnvironmentPropertyTests.java

+1-1
Original file line numberDiff line numberDiff line change
@@ -44,7 +44,7 @@
4444
@SpringBootTest
4545
@ActiveProfiles({ "test1", "test2" })
4646
@ContextConfiguration(loader = SpringBootTestWithActiveProfilesAndSystemEnvironmentPropertyTests.Loader.class)
47-
public class SpringBootTestWithActiveProfilesAndSystemEnvironmentPropertyTests {
47+
class SpringBootTestWithActiveProfilesAndSystemEnvironmentPropertyTests {
4848

4949
@Autowired
5050
private Environment environment;

spring-boot-project/spring-boot-test/src/test/java/org/springframework/boot/test/web/reactive/server/WebTestClientContextCustomizerWithoutSupportedHttpClientTests.java

+1-1
Original file line numberDiff line numberDiff line change
@@ -33,7 +33,7 @@
3333
* @author Andy Wilkinson
3434
*/
3535
@ClassPathExclusions({ "reactor-netty*.jar", "jetty-client*.jar" })
36-
public class WebTestClientContextCustomizerWithoutSupportedHttpClientTests {
36+
class WebTestClientContextCustomizerWithoutSupportedHttpClientTests {
3737

3838
@Test
3939
void createContextCustomizerWhenNoSupportedHttpClientIsAvailableShouldReturnNull() {

spring-boot-project/spring-boot-test/src/test/java/org/springframework/boot/test/web/reactive/server/WebTestClientContextCustomizerWithoutWebfluxIntegrationTests.java

+1-1
Original file line numberDiff line numberDiff line change
@@ -34,7 +34,7 @@
3434
* @author Stephane Nicoll
3535
*/
3636
@ClassPathExclusions("spring-webflux*.jar")
37-
public class WebTestClientContextCustomizerWithoutWebfluxIntegrationTests {
37+
class WebTestClientContextCustomizerWithoutWebfluxIntegrationTests {
3838

3939
@Test
4040
void customizerIsNotCreatedWithoutWebClient() {

spring-boot-project/spring-boot-tools/spring-boot-buildpack-platform/src/test/java/org/springframework/boot/buildpack/platform/build/BuildRequestTests.java

+1-1
Original file line numberDiff line numberDiff line change
@@ -44,7 +44,7 @@
4444
* @author Phillip Webb
4545
* @author Scott Frederick
4646
*/
47-
public class BuildRequestTests {
47+
class BuildRequestTests {
4848

4949
@TempDir
5050
File tempDir;

spring-boot-project/spring-boot-tools/spring-boot-buildpack-platform/src/test/java/org/springframework/boot/buildpack/platform/docker/configuration/DockerConfigurationTests.java

+1-1
Original file line numberDiff line numberDiff line change
@@ -26,7 +26,7 @@
2626
* @author Wei Jiang
2727
* @author Scott Frederick
2828
*/
29-
public class DockerConfigurationTests {
29+
class DockerConfigurationTests {
3030

3131
@Test
3232
void createDockerConfigurationWithDefaults() {

spring-boot-project/spring-boot-tools/spring-boot-gradle-plugin/src/test/java/org/springframework/boot/gradle/tasks/bundling/BootBuildImageRegistryIntegrationTests.java

+1-1
Original file line numberDiff line numberDiff line change
@@ -49,7 +49,7 @@
4949
@GradleCompatibility
5050
@Testcontainers(disabledWithoutDocker = true)
5151
@Disabled("Disabled until differences between running locally and in CI can be diagnosed")
52-
public class BootBuildImageRegistryIntegrationTests {
52+
class BootBuildImageRegistryIntegrationTests {
5353

5454
@Container
5555
static final RegistryContainer registry = new RegistryContainer().withStartupAttempts(5)

spring-boot-project/spring-boot-tools/spring-boot-gradle-plugin/src/test/java/org/springframework/boot/gradle/tasks/bundling/DockerSpecTests.java

+1-1
Original file line numberDiff line numberDiff line change
@@ -32,7 +32,7 @@
3232
* @author Wei Jiang
3333
* @author Scott Frederick
3434
*/
35-
public class DockerSpecTests {
35+
class DockerSpecTests {
3636

3737
@Test
3838
void asDockerConfigurationWithDefaults() {

spring-boot-project/spring-boot-tools/spring-boot-maven-plugin/src/intTest/java/org/springframework/boot/maven/BuildInfoIntegrationTests.java

+1-1
Original file line numberDiff line numberDiff line change
@@ -37,7 +37,7 @@
3737
* @author Andy Wilkinson
3838
*/
3939
@ExtendWith(MavenBuildExtension.class)
40-
public class BuildInfoIntegrationTests {
40+
class BuildInfoIntegrationTests {
4141

4242
@TestTemplate
4343
void buildInfoPropertiesAreGenerated(MavenBuild mavenBuild) {

spring-boot-project/spring-boot-tools/spring-boot-maven-plugin/src/intTest/java/org/springframework/boot/maven/EclipseM2eIntegrationTests.java

+1-1
Original file line numberDiff line numberDiff line change
@@ -32,7 +32,7 @@
3232
*
3333
* @author Phillip Webb
3434
*/
35-
public class EclipseM2eIntegrationTests {
35+
class EclipseM2eIntegrationTests {
3636

3737
@Test // gh-21992
3838
void pluginPomIncludesOptionalShadeDependency() throws Exception {

spring-boot-project/spring-boot-tools/spring-boot-maven-plugin/src/test/java/org/springframework/boot/maven/CustomLayersProviderTests.java

+1-1
Original file line numberDiff line numberDiff line change
@@ -40,7 +40,7 @@
4040
* @author Madhura Bhave
4141
* @author Scott Frederick
4242
*/
43-
public class CustomLayersProviderTests {
43+
class CustomLayersProviderTests {
4444

4545
private CustomLayersProvider customLayersProvider;
4646

spring-boot-project/spring-boot-tools/spring-boot-maven-plugin/src/test/java/org/springframework/boot/maven/DockerTests.java

+1-1
Original file line numberDiff line numberDiff line change
@@ -31,7 +31,7 @@
3131
* @author Wei Jiang
3232
* @author Scott Frederick
3333
*/
34-
public class DockerTests {
34+
class DockerTests {
3535

3636
@Test
3737
void asDockerConfigurationWithDefaults() {

spring-boot-project/spring-boot/src/test/java/org/springframework/boot/context/config/ConfigTreeConfigDataLoaderTests.java

+1-1
Original file line numberDiff line numberDiff line change
@@ -37,7 +37,7 @@
3737
* @author Madhura Bhave
3838
* @author Phillip Webb
3939
*/
40-
public class ConfigTreeConfigDataLoaderTests {
40+
class ConfigTreeConfigDataLoaderTests {
4141

4242
private ConfigTreeConfigDataLoader loader = new ConfigTreeConfigDataLoader();
4343

spring-boot-project/spring-boot/src/test/java/org/springframework/boot/context/config/ConfigTreeConfigDataResourceTests.java

+1-1
Original file line numberDiff line numberDiff line change
@@ -30,7 +30,7 @@
3030
* @author Madhura Bhave
3131
* @author Phillip Webb
3232
*/
33-
public class ConfigTreeConfigDataResourceTests {
33+
class ConfigTreeConfigDataResourceTests {
3434

3535
@Test
3636
void constructorWhenPathStringIsNullThrowsException() {

spring-boot-project/spring-boot/src/test/java/org/springframework/boot/context/config/StandardConfigDataLoaderTests.java

+1-1
Original file line numberDiff line numberDiff line change
@@ -34,7 +34,7 @@
3434
* @author Madhura Bhave
3535
* @author Phillip Webb
3636
*/
37-
public class StandardConfigDataLoaderTests {
37+
class StandardConfigDataLoaderTests {
3838

3939
private StandardConfigDataLoader loader = new StandardConfigDataLoader();
4040

spring-boot-project/spring-boot/src/test/java/org/springframework/boot/context/config/StandardConfigDataLocationResolverTests.java

+1-1
Original file line numberDiff line numberDiff line change
@@ -44,7 +44,7 @@
4444
* @author Madhura Bhave
4545
* @author Phillip Webb
4646
*/
47-
public class StandardConfigDataLocationResolverTests {
47+
class StandardConfigDataLocationResolverTests {
4848

4949
private StandardConfigDataLocationResolver resolver;
5050

spring-boot-project/spring-boot/src/test/java/org/springframework/boot/context/config/StandardConfigDataResourceTests.java

+1-1
Original file line numberDiff line numberDiff line change
@@ -31,7 +31,7 @@
3131
* @author Madhura Bhave
3232
* @author Phillip Webb
3333
*/
34-
public class StandardConfigDataResourceTests {
34+
class StandardConfigDataResourceTests {
3535

3636
StandardConfigDataReference reference = mock(StandardConfigDataReference.class);
3737

spring-boot-project/spring-boot/src/test/java/org/springframework/boot/context/properties/bind/BoundPropertiesTrackingBindHandlerTests.java

+1-1
Original file line numberDiff line numberDiff line change
@@ -41,7 +41,7 @@
4141
* @author Madhura Bhave
4242
*/
4343
@ExtendWith(MockitoExtension.class)
44-
public class BoundPropertiesTrackingBindHandlerTests {
44+
class BoundPropertiesTrackingBindHandlerTests {
4545

4646
private List<ConfigurationPropertySource> sources = new ArrayList<>();
4747

spring-boot-project/spring-boot/src/test/java/org/springframework/boot/web/client/RestTemplateBuilderClientHttpRequestInitializerTests.java

+1-1
Original file line numberDiff line numberDiff line change
@@ -43,7 +43,7 @@
4343
* @author Ilya Lukyanovich
4444
* @author Phillip Webb
4545
*/
46-
public class RestTemplateBuilderClientHttpRequestInitializerTests {
46+
class RestTemplateBuilderClientHttpRequestInitializerTests {
4747

4848
private final MockClientHttpRequest request = new MockClientHttpRequest();
4949

spring-boot-project/spring-boot/src/test/java/org/springframework/boot/web/context/WebServerApplicationContextTests.java

+1-1
Original file line numberDiff line numberDiff line change
@@ -29,7 +29,7 @@
2929
*
3030
* @author Phillip Webb
3131
*/
32-
public class WebServerApplicationContextTests {
32+
class WebServerApplicationContextTests {
3333

3434
@Test
3535
void hasServerNamespaceWhenContextIsNotWebServerApplicationContextReturnsFalse() {

0 commit comments

Comments
 (0)