Skip to content

Commit 9ff349b

Browse files
author
Adrian Cole
committed
deps: bumps to Brave 6.0.0 and moves off internal type
This updates to Brave 6.0.0 and dodges an internal type that is not in it. Brave 6 works with both zipkin-reporter 2 and 3, and no longer manages versions for it. Since this codebase currently uses zipkin-reporter 2, I added the bom for it. I can do a separate PR to migrate code to zipkin-reporter 3 next. Signed-off-by: Adrian Cole <[email protected]>
1 parent 93a2b1c commit 9ff349b

File tree

5 files changed

+14
-14
lines changed

5 files changed

+14
-14
lines changed

Diff for: spring-boot-project/spring-boot-actuator-autoconfigure/src/main/java/org/springframework/boot/actuate/autoconfigure/tracing/BravePropagationConfigurations.java

+1-4
Original file line numberDiff line numberDiff line change
@@ -30,7 +30,6 @@
3030
import brave.propagation.CurrentTraceContext.ScopeDecorator;
3131
import brave.propagation.Propagation;
3232
import brave.propagation.Propagation.Factory;
33-
import brave.propagation.Propagation.KeyFactory;
3433

3534
import org.springframework.beans.factory.ObjectProvider;
3635
import org.springframework.boot.actuate.autoconfigure.tracing.TracingProperties.Baggage.Correlation;
@@ -97,12 +96,10 @@ BaggagePropagation.FactoryBuilder propagationFactoryBuilder(
9796
return builder;
9897
}
9998

100-
@SuppressWarnings("deprecation")
10199
private Factory createThrowAwayFactory() {
102100
return new Factory() {
103-
104101
@Override
105-
public <K> Propagation<K> create(KeyFactory<K> keyFactory) {
102+
public Propagation<String> get() {
106103
return null;
107104
}
108105

Diff for: spring-boot-project/spring-boot-actuator-autoconfigure/src/main/java/org/springframework/boot/actuate/autoconfigure/tracing/CompositePropagationFactory.java

+2-4
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,6 @@
2222
import java.util.function.Predicate;
2323
import java.util.stream.Stream;
2424

25-
import brave.internal.propagation.StringPropagationAdapter;
2625
import brave.propagation.B3Propagation;
2726
import brave.propagation.Propagation;
2827
import brave.propagation.Propagation.Factory;
@@ -71,9 +70,8 @@ public boolean requires128BitTraceId() {
7170
}
7271

7372
@Override
74-
@SuppressWarnings("deprecation")
75-
public <K> Propagation<K> create(Propagation.KeyFactory<K> keyFactory) {
76-
return StringPropagationAdapter.create(this.propagation, keyFactory);
73+
public Propagation<String> get() {
74+
return this.propagation;
7775
}
7876

7977
@Override

Diff for: spring-boot-project/spring-boot-actuator-autoconfigure/src/test/java/org/springframework/boot/actuate/autoconfigure/tracing/CompositePropagationFactoryTests.java

+2-4
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,6 @@
2121
import java.util.List;
2222
import java.util.Map;
2323

24-
import brave.internal.propagation.StringPropagationAdapter;
2524
import brave.propagation.Propagation;
2625
import brave.propagation.TraceContext;
2726
import brave.propagation.TraceContextOrSamplingFlags;
@@ -143,9 +142,8 @@ private DummyPropagation(String field) {
143142
}
144143

145144
@Override
146-
@SuppressWarnings("deprecation")
147-
public <K> Propagation<K> create(Propagation.KeyFactory<K> keyFactory) {
148-
return StringPropagationAdapter.create(this, keyFactory);
145+
public Propagation<String> get() {
146+
return this;
149147
}
150148

151149
@Override

Diff for: spring-boot-project/spring-boot-actuator-autoconfigure/src/test/java/org/springframework/boot/actuate/autoconfigure/tracing/LocalBaggageFieldsTests.java

+1-1
Original file line numberDiff line numberDiff line change
@@ -54,7 +54,7 @@ void empty() {
5454
private static FactoryBuilder createBuilder() {
5555
return BaggagePropagation.newFactoryBuilder(new Factory() {
5656
@Override
57-
public <K> Propagation<K> create(KeyFactory<K> keyFactory) {
57+
public Propagation<String> get() {
5858
return null;
5959
}
6060
});

Diff for: spring-boot-project/spring-boot-dependencies/build.gradle

+8-1
Original file line numberDiff line numberDiff line change
@@ -109,13 +109,20 @@ bom {
109109
]
110110
}
111111
}
112-
library("Brave", "5.17.0") {
112+
library("Brave", "6.0.0") {
113113
group("io.zipkin.brave") {
114114
imports = [
115115
"brave-bom"
116116
]
117117
}
118118
}
119+
library("Zipkin Reporter", "2.17.2") {
120+
group("io.zipkin.reporter2") {
121+
imports = [
122+
"zipkin-reporter-bom"
123+
]
124+
}
125+
}
119126
library("Build Helper Maven Plugin", "3.5.0") {
120127
group("org.codehaus.mojo") {
121128
plugins = [

0 commit comments

Comments
 (0)