Skip to content

Commit ec68360

Browse files
committed
Polish "Allow to configure Kafka Listener's onlyLogRecordMetadata"
See gh-24582
1 parent b539e2e commit ec68360

File tree

3 files changed

+5
-4
lines changed

3 files changed

+5
-4
lines changed

Diff for: spring-boot-project/spring-boot-autoconfigure/src/main/java/org/springframework/boot/autoconfigure/kafka/ConcurrentKafkaListenerContainerFactoryConfigurer.java

+1-1
Original file line numberDiff line numberDiff line change
@@ -189,7 +189,7 @@ private void configureContainer(ContainerProperties container) {
189189
map.from(properties::getMonitorInterval).as(Duration::getSeconds).as(Number::intValue)
190190
.to(container::setMonitorInterval);
191191
map.from(properties::getLogContainerConfig).to(container::setLogContainerConfig);
192-
map.from(properties::getOnlyLogRecordMetadata).to(container::setOnlyLogRecordMetadata);
192+
map.from(properties::isOnlyLogRecordMetadata).to(container::setOnlyLogRecordMetadata);
193193
map.from(properties::isMissingTopicsFatal).to(container::setMissingTopicsFatal);
194194
map.from(this.transactionManager).to(container::setTransactionManager);
195195
map.from(this.rebalanceListener).to(container::setConsumerRebalanceListener);

Diff for: spring-boot-project/spring-boot-autoconfigure/src/main/java/org/springframework/boot/autoconfigure/kafka/KafkaProperties.java

+3-3
Original file line numberDiff line numberDiff line change
@@ -917,7 +917,7 @@ public enum Type {
917917
* Whether to suppress the entire record from being written to the log when
918918
* retries are being attempted.
919919
*/
920-
private Boolean onlyLogRecordMetadata;
920+
private boolean onlyLogRecordMetadata;
921921

922922
/**
923923
* Whether the container should fail to start if at least one of the configured
@@ -1021,11 +1021,11 @@ public void setLogContainerConfig(Boolean logContainerConfig) {
10211021
this.logContainerConfig = logContainerConfig;
10221022
}
10231023

1024-
public Boolean getOnlyLogRecordMetadata() {
1024+
public boolean isOnlyLogRecordMetadata() {
10251025
return this.onlyLogRecordMetadata;
10261026
}
10271027

1028-
public void setOnlyLogRecordMetadata(Boolean onlyLogRecordMetadata) {
1028+
public void setOnlyLogRecordMetadata(boolean onlyLogRecordMetadata) {
10291029
this.onlyLogRecordMetadata = onlyLogRecordMetadata;
10301030
}
10311031

Diff for: spring-boot-project/spring-boot-autoconfigure/src/test/java/org/springframework/boot/autoconfigure/kafka/KafkaPropertiesTests.java

+1
Original file line numberDiff line numberDiff line change
@@ -47,6 +47,7 @@ void isolationLevelEnumConsistentWithKafkaVersion() {
4747
void listenerDefaultValuesAreConsistent() {
4848
ContainerProperties container = new ContainerProperties("test");
4949
Listener listenerProperties = new KafkaProperties().getListener();
50+
assertThat(listenerProperties.isOnlyLogRecordMetadata()).isEqualTo(container.isOnlyLogRecordMetadata());
5051
assertThat(listenerProperties.isMissingTopicsFatal()).isEqualTo(container.isMissingTopicsFatal());
5152
}
5253

0 commit comments

Comments
 (0)