Skip to content

Upgrade to Mockito 2.10.0 #10245

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wilkinsona opened this issue Sep 11, 2017 · 3 comments
Closed

Upgrade to Mockito 2.10.0 #10245

wilkinsona opened this issue Sep 11, 2017 · 3 comments
Assignees
Labels
type: dependency-upgrade A dependency upgrade

Comments

@wilkinsona
Copy link
Member

wilkinsona commented Sep 11, 2017

There are some small breaking changes involved here

@wilkinsona wilkinsona added this to the 2.0.0.M4 milestone Sep 11, 2017
@wilkinsona
Copy link
Member Author

Let's wait for the resolution of #10247 before tackling this.

@wilkinsona wilkinsona removed this from the 2.0.0.M4 milestone Sep 11, 2017
@TimvdLippe
Copy link

I would like to make Spring also aware of the commitment of Mockito to support all projects by our public API. If you are relying on internal (org.mockito.internal.*) implementation, we can not guarantee no breaking changes on minor/patch updates.

Lately @szczepiq has worked on supporting PowerMockito with only a public API (check out mockito/mockito#1110) and we would like to do this for other frameworks as well. If you would like to spend some more effort and time on this issue, feel free to reach out to us to start the discussion!

And as always, thanks for using Mockito 😄

(We are especially focusing on this issue with the upcoming modularization of Java 9, which might break existing projects)

@philwebb
Copy link
Member

Thanks @TimvdLippe. I've raised #10352 to see if we can address this. I have a feeling that it might be difficult to get there with Spring Boot 2.0, but we should certainly try.

@wilkinsona wilkinsona self-assigned this Sep 20, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: dependency-upgrade A dependency upgrade
Projects
None yet
Development

No branches or pull requests

3 participants