Skip to content

Don't cause early initialization from WebMvcMetricsFilter #11571

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
philwebb opened this issue Jan 8, 2018 · 0 comments
Closed

Don't cause early initialization from WebMvcMetricsFilter #11571

philwebb opened this issue Jan 8, 2018 · 0 comments
Assignees
@philwebb
Labels
type: enhancement A general enhancement
Milestone
2.0.0.RC1

Comments

@philwebb
Copy link
Member

philwebb commented Jan 8, 2018

The WebMvcMetricsFilter causes many beans to be pulled in much earlier than in 1.5. Profiling an application shows much of the work now happens in a Tomcat thread rather than the main thread. We should probably make the filter lazy like we did with Spring Security.
@philwebb philwebb added priority: high type: enhancement A general enhancement labels Jan 8, 2018
@philwebb philwebb self-assigned this Jan 8, 2018
@philwebb philwebb added this to the 2.0.0.RC1 milestone Jan 8, 2018
@philwebb philwebb mentioned this issue Jan 8, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@philwebb philwebb

Labels
type: enhancement A general enhancement
Projects
None yet
Milestone
2.0.0.RC1
Development

No branches or pull requests
1 participant
@philwebb