Skip to content

Document how to build images when behind an HTTP proxy #19984

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wilkinsona opened this issue Jan 29, 2020 · 2 comments
Closed

Document how to build images when behind an HTTP proxy #19984

wilkinsona opened this issue Jan 29, 2020 · 2 comments
Assignees
Labels
type: documentation A documentation update
Milestone

Comments

@wilkinsona
Copy link
Member

This was raised in the comments on the blog post about creating Docker images. I think it should be possible to get it to work by passing HTTP_PROXY or HTTPS_PROXY environment variables into the builder. We should explore the possibility of setting those automatically based on the proxy settings that Gradle or Maven are using.

@wilkinsona wilkinsona added this to the 2.3.x milestone Jan 29, 2020
@wilkinsona wilkinsona added the type: enhancement A general enhancement label Jan 29, 2020
@wilkinsona
Copy link
Member Author

In the light of #20538, this is probably a bit more complex than I had first realised. If the user has configured DOCKER_HOST, the Docker daemon may be running in an environment where the user's local proxy settings aren't applicable. Perhaps we should only try to pass the local proxy configuration into the builder when DOCKER_HOST has not been set.

@scottfrederick scottfrederick self-assigned this Apr 2, 2020
@wilkinsona wilkinsona changed the title Make it easier to build images when behind an HTTP proxy Document how to build images when behind an HTTP proxy Apr 3, 2020
@wilkinsona wilkinsona added type: documentation A documentation update and removed type: enhancement A general enhancement labels Apr 3, 2020
@wilkinsona
Copy link
Member Author

There are too many edges cases here for us to be able to reliably configure the current proxy settings. Rather than trying to guess and cause hard to diagnose problems when we get it wrong, we should document how users can configure things themselves.

@scottfrederick scottfrederick modified the milestones: 2.3.x, 2.3.0.RC1 Apr 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: documentation A documentation update
Projects
None yet
Development

No branches or pull requests

2 participants