Skip to content

Add Maven smoke tests #20153

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
snicoll opened this issue Feb 13, 2020 · 2 comments
Closed

Add Maven smoke tests #20153

snicoll opened this issue Feb 13, 2020 · 2 comments
Labels
for: external-project For an external project and not something we can fix type: task A general task

Comments

@snicoll
Copy link
Member

snicoll commented Feb 13, 2020

The move to Gradle makes it less obvious to see warnings Maven would emit when resolving a standard project. In the recent past, we got a few already:

  • encoding not set in starter parent leading to a warning in the log (and the lost of UTF-8 encoding in favour of the local encoding)
  • wrong version reference in maven-shade-plugin configuration, leading to a failure when trying to invoke it
  • Invalid or incomplete BOMs. The current infinispan BOM has a reference to a non-existent artifact which leads to this warning:
[WARNING] The POM for org.infinispan:infinispan-protocol-parser-generator-maven-plugin:jar:10.1.1.Final is missing, no dependency information available
[WARNING] Failed to retrieve plugin descriptor for org.infinispan:infinispan-protocol-parser-generator-maven-plugin:10.1.1.Final: Plugin org.infinispan:infinispan-protocol-parser-generator-maven-plugin:10.1.1.Final or one of its dependencies could not be resolved: Failure to find org.infinispan:infinispan-protocol-parser-generator-maven-plugin:jar:10.1.1.Final in https://repo.spring.io/milestone was cached in the local repository, resolution will not be reattempted until the update interval of spring-milestones has elapsed or updates are forced

Building small projects with Maven and validating the lack of warnings would be already a good first step. Perhaps we could use the Maven API to validate things automatically?

@snicoll snicoll added the type: task A general task label Feb 13, 2020
@snicoll snicoll added this to the 2.3.x milestone Feb 13, 2020
@wilkinsona
Copy link
Member

Hopefully, some smoke tests would catch problems like #21304 as well.

@wilkinsona wilkinsona modified the milestones: 2.3.x, 2.4.x Jun 10, 2021
@wilkinsona wilkinsona modified the milestones: 2.4.x, 2.5.x Nov 15, 2021
@wilkinsona wilkinsona modified the milestones: 2.5.x, 2.6.x May 19, 2022
@philwebb philwebb modified the milestones: 2.6.x, General Backlog Jun 16, 2022
@wilkinsona
Copy link
Member

If we want to do this, it should be done as part of the release verification tests.

@wilkinsona wilkinsona closed this as not planned Won't fix, can't repro, duplicate, stale May 31, 2024
@wilkinsona wilkinsona removed this from the General Backlog milestone May 31, 2024
@wilkinsona wilkinsona added the for: external-project For an external project and not something we can fix label May 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
for: external-project For an external project and not something we can fix type: task A general task
Projects
None yet
Development

No branches or pull requests

3 participants