Skip to content

Rename "classes" concept to "application" in custom layer configuration #20539

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
snicoll opened this issue Mar 17, 2020 · 4 comments
Closed
Assignees
Labels
status: noteworthy A noteworthy issue to call out in the release notes type: enhancement A general enhancement
Milestone

Comments

@snicoll
Copy link
Member

snicoll commented Mar 17, 2020

As a follow-up of #20526 I feel that renaming the XML element from classes to application would be consistent. This section currently handles anything that's in BOOT-INF/classes but the content is not only classes.

This made the documentation in the XSD quite awkward.

This also impacts the Gradle DSL.

@snicoll snicoll added for: team-attention An issue we'd like other members of the team to review status: waiting-for-triage An issue we've not yet triaged labels Mar 17, 2020
@wilkinsona
Copy link
Member

+1 for reworking the XML and Gradle DSL. I also think we should consider some changes to the class names rather than just changing their packages. I'm going to re-open #20526 so that we can handle all API changes in one place. We can then use this issue for Maven/Gradle configuration changes.

@wilkinsona
Copy link
Member

I'm wavering a bit on the application name now. Using it would result in configuration that might look like this:

<application>
	<layer-content layer="resources">
		<locations>
			<include>META-INF/resources/**</include>
			<include>resources/**</include>
			<include>static/**</include>
			<include>public/**</include>
		</locations>
	</layer-content>
	<layer-content layer="application">
		<locations>
			<include>**</include>
		</locations>
	</layer-content>
</application>

I find it a little confusing that the outer element is called application while there's also a layer called application. I think we could do with a different name for one of them but I'm struggling to think of one right now.

@mbhave
Copy link
Contributor

mbhave commented Mar 17, 2020

I had the same concern for renaming the tag name to application. However now that I think about it, I think application makes sense for the element name since everything under it is tied to application code. Although I can't think of another name for the application layer either.

@wilkinsona
Copy link
Member

We've decided to go with the classes -> application rename that's proposed here in the XML. We've also decided to combine the current resources and application layers into a single layer named application. That addresses the naming problem as the default application layer will then contain all of the application content. I've opened #20562 for that.

@wilkinsona wilkinsona added type: enhancement A general enhancement and removed for: team-attention An issue we'd like other members of the team to review status: waiting-for-triage An issue we've not yet triaged labels Mar 18, 2020
@wilkinsona wilkinsona added this to the 2.3.x milestone Mar 18, 2020
@mbhave mbhave self-assigned this Mar 18, 2020
@mbhave mbhave added the status: noteworthy A noteworthy issue to call out in the release notes label Mar 19, 2020
@mbhave mbhave closed this as completed in 952e529 Mar 23, 2020
@mbhave mbhave modified the milestones: 2.3.x, 2.3.0.M4 Mar 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: noteworthy A noteworthy issue to call out in the release notes type: enhancement A general enhancement
Projects
None yet
Development

No branches or pull requests

3 participants