Skip to content

Polish PR "Dependency Upgrades" section #20707

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
snicoll opened this issue Mar 28, 2020 · 1 comment
Closed

Polish PR "Dependency Upgrades" section #20707

snicoll opened this issue Mar 28, 2020 · 1 comment
Labels
status: declined A suggestion or change that we don't feel we should currently apply

Comments

@snicoll
Copy link
Member

snicoll commented Mar 28, 2020

Our PR template for dependency upgrades currently states:

Dependency Upgrades

Please do not open a pull request for a straightforward dependency upgrade (one that
only updates the version property). We have a semi-automated process for such upgrades
that we prefer to use. However, if the upgrade is more involved (such as requiring
changes for removed or deprecated API) your pull request is most welcome.

I think a key element is missing in this text. Rather than focusing on the fact it only updates one line with a version property, we should IMO focus on the fact it is covered by bomr and therefore will be taken care "automatically".

Versions that are handled internally (and aren't covered by bomr) won't be checked automatically and can be outdated unless someone looks at it. Any help we can get to stay current is most welcome.

Maybe we could rephrase the text to mention the content of spring-boot-dependencies since that's what bomr uses?

@snicoll snicoll added status: waiting-for-feedback We need additional information before we can continue for: team-attention An issue we'd like other members of the team to review labels Mar 28, 2020
@snicoll snicoll changed the title Polish PR dependency upgrades message Polish PR "Dependency Upgrades" section Mar 28, 2020
@snicoll snicoll added status: waiting-for-triage An issue we've not yet triaged and removed status: waiting-for-feedback We need additional information before we can continue labels Apr 1, 2020
@philwebb philwebb added type: task A general task and removed for: team-attention An issue we'd like other members of the team to review status: waiting-for-triage An issue we've not yet triaged type: task A general task labels May 13, 2020
@snicoll
Copy link
Member Author

snicoll commented May 13, 2020

We've decided to keep the note as it is and expand bomr coverage, see #21439. We will merge PRs that only update the version property on a case-by-case basis. For internal dependencies, we feel it is less important to upgrade right away unless there is a benefit in doing so.

@snicoll snicoll closed this as completed May 13, 2020
@snicoll snicoll added the status: declined A suggestion or change that we don't feel we should currently apply label May 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: declined A suggestion or change that we don't feel we should currently apply
Projects
None yet
Development

No branches or pull requests

2 participants