Skip to content

toolchain not working when fork=false #21543

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
jbkervyn opened this issue May 22, 2020 · 1 comment
Closed

toolchain not working when fork=false #21543

jbkervyn opened this issue May 22, 2020 · 1 comment
Labels
status: superseded An issue that has been superseded by another type: enhancement A general enhancement

Comments

@jbkervyn
Copy link

When configuring the boot plugin in fork=false (not default). The toolchains plugin has not effect and does not behave the way expected.

Nothing is displayed during the maven execution.

Expected behavior : proper execution of the spring-boot:run with the corresponding JDK or a warning explaining that this doesn't work when not forked

Suggestion for improvement : most plugin do display the use of the JDK selected by toolchain (compiler, surefire, failsafe), I guess it would make sense to do the same with the boot plugin.

See attached project demonstrating the issue

test-toolchain.zip

@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label May 22, 2020
@philwebb philwebb added type: enhancement A general enhancement and removed status: waiting-for-triage An issue we've not yet triaged labels May 27, 2020
@philwebb philwebb added this to the 2.x milestone May 27, 2020
@wilkinsona
Copy link
Member

Superseded by #30479.

@wilkinsona wilkinsona removed this from the 2.x milestone Apr 26, 2022
@wilkinsona wilkinsona added the status: superseded An issue that has been superseded by another label Apr 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: superseded An issue that has been superseded by another type: enhancement A general enhancement
Projects
None yet
Development

No branches or pull requests

4 participants