Skip to content

Extend HttpSessionEventPublisher to propagate HttpSessionIdListener events. #24985

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
mahairod opened this issue Jan 24, 2021 · 3 comments
Closed
Labels
status: invalid An issue that we don't feel is valid

Comments

@mahairod
Copy link

mahairod commented Jan 24, 2021

As additional funcvtionality for #24879 it's convenient to add support for propagating of session id changes to spring context. It's possible through the same HttpSessionEventPublisher used for session creation and destroy events. It's also necessary to add another HttpSessionEvent reflecting new type of event.

@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Jan 24, 2021
@wilkinsona
Copy link
Member

Thanks for the suggestion. Unfortunately, I'm not sure that I have understood what you are proposing we do in Spring Boot. Spring Security's HttpSessionEventPublisher is already an HttpSessionIdListener and, in response to a sessionIdChanged callback, it will publish a HttpSessionIdChangedEvent. This functionality was added in Spring Security 5.4.

@wilkinsona wilkinsona added the status: waiting-for-feedback We need additional information before we can continue label Jan 24, 2021
@mahairod
Copy link
Author

Oh, sorry! My bad. I missed that functionality because it became available just few months ago.

@spring-projects-issues spring-projects-issues added status: feedback-provided Feedback has been provided and removed status: waiting-for-feedback We need additional information before we can continue labels Jan 24, 2021
@mahairod
Copy link
Author

Already present

@wilkinsona wilkinsona added status: invalid An issue that we don't feel is valid and removed status: feedback-provided Feedback has been provided status: waiting-for-triage An issue we've not yet triaged labels Jan 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: invalid An issue that we don't feel is valid
Projects
None yet
Development

No branches or pull requests

3 participants