Provide a mechanism to disable MetricFilterAutoConfiguration's metric filter

[paskos]

Our project already uses Dropwizard com.codahale.metrics.servlet.InstrumentedFilter.
For us MetricFilterAutoConfiguration.MetricsFilter adds noise to our ops team with its added metrics.
We would like to remove it but we could not find a way.
One "easy" way would be for MetricFilterAutoConfiguration.MetricsFilter to be @ConditionalOnMissingBean(name="metricFilter")

[wilkinsona]

If you don't want the metricFilter bean to be created you can disable the auto-configuration:

@SpringBootApplication(exclude=MetricFilterAutoConfiguration.class)

[paskos]

Unfortunately it's not possible.
Our Main class annotated with @SpringBootApplication is in a core project without dependency to spring-boot-actuator.jar.

[wilkinsona]

Making the bean @ConditionalOnProperty is more consistent with the rest of Spring Boot. See PersistenceExceptionTranslationAutoConfiguration, for example

[paskos]

I don't mind what type of @ConditionalOn as long as it is configurable

[cemo]

I have opened two issue and both of them are resolving this issue. Please see #2661 and see #2660.

[wilkinsona]

This was fixed in d0cf6b5. endpoints.metrics.filter.enabled: false can now be used to turn the filter off. Alternatively, the whole auto-configuration can be excluded by class name thanks to a6f671b.

[paskos]

Thanks a lot guys !!!

[khong07]

Hi,

I'm on spring boot 1.3.0.RELEASE but the property is endpoints.metrics.enabled and not endpoints.metrics.filter.enabled.

[wilkinsona]

@khong07 Thanks for pointing this out. That shouldn't be the case. #4365 will reinstate endpoints.metrics.filter.enabled and allow the filter to be switched off independently.