Skip to content

Remove remaining code that was deprecated in 2.5 #30442

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wilkinsona opened this issue Mar 25, 2022 · 3 comments
Closed

Remove remaining code that was deprecated in 2.5 #30442

wilkinsona opened this issue Mar 25, 2022 · 3 comments
Assignees
Labels
type: task A general task
Milestone

Comments

@wilkinsona
Copy link
Member

While looking at #30435, I noticed that the DB initialization related properties on DataSourceProperties that were deprecated in 2.5 have not been removed. I suspect they were missed during #29290 as they're configuration properties so there was no "deprecated since 2.5.0 for removal in 2.7.0" to look for.

@IAmSSH
Copy link

IAmSSH commented Mar 26, 2022

Hi @wilkinsona
Can I work on this issue?
Though the issue is not labeled explicitly for first-timers, I would like to give it a try if you don't mind.
Could you perhaps provide a little bit of guidance about what needs to be done?

@wilkinsona
Copy link
Member Author

Thanks for the offer, @IAmSSH. If you’d like to work on an issue where we provide some guidance, please watch for one labelled as ideal for contribution or, if you haven’t contributed before, first-timers only.

@snicoll
Copy link
Member

snicoll commented Apr 3, 2022

A note that there are a number of tests that are still relying on spring.datasource.intialization-mode. When removing the properties for this, we should review manual metadata as well.

@wilkinsona wilkinsona self-assigned this Apr 13, 2022
@wilkinsona wilkinsona modified the milestones: 2.7.x, 2.7.0-RC1 Apr 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: task A general task
Projects
None yet
Development

No branches or pull requests

3 participants