Skip to content

BatchDataSourceScriptDatabaseInitializer does not find the Oracle schema scripts #30564

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wilkinsona opened this issue Apr 6, 2022 · 4 comments
Assignees
Labels
type: bug A general bug
Milestone

Comments

@wilkinsona
Copy link
Member

The script's been renamed in 5.0.0-M2 so we won't find it any more. Ideally, a test would have caught this when we upgraded to 5.0.0-M2. We should look at adding one as part of fixing this.

@wilkinsona wilkinsona added this to the 3.0.x milestone Apr 6, 2022
@wilkinsona wilkinsona added the type: bug A general bug label Apr 6, 2022
@pruidong
Copy link
Contributor

pruidong commented Apr 7, 2022

You mean you need to modify: BatchDataSourceScriptDatabaseInitializer.java#L81

platformResolver = platformResolver.withDriverPlatform(DatabaseDriver.ORACLE, "oracle10g");

This line? Can I submit a pull request?

@snicoll
Copy link
Member

snicoll commented Apr 7, 2022

@pruidong thanks for the offer but Andy mentioned a test should have failed and hasn't so it is more than just changing the line.

@pruidong
Copy link
Contributor

pruidong commented Apr 7, 2022

@pruidong thanks for the offer but Andy mentioned a test should have failed and hasn't so it is more than just changing the line.

Okay thank you.

@wilkinsona
Copy link
Member Author

Improving the tests has been separated out into #30794 so that it can be done in earlier branches.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: bug A general bug
Projects
None yet
Development

No branches or pull requests

3 participants