Skip to content

Rename jmx start/stop bean #3124

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
philwebb opened this issue Jun 4, 2015 · 6 comments
Closed

Rename jmx start/stop bean #3124

philwebb opened this issue Jun 4, 2015 · 6 comments
Assignees
Milestone

Comments

@philwebb
Copy link
Member

philwebb commented Jun 4, 2015

The current name (org.springframework.boot:type=Lifecycle,name=springApplicationLifecycle) could be renamed to org.springframework.boot:type=Lifecycle,name=SpringApplication

@philwebb philwebb added this to the 1.3.0.M1 milestone Jun 4, 2015
@philwebb
Copy link
Member Author

philwebb commented Jun 5, 2015

LiveBeansView from Spring Framework might be a good guide.

@snicoll snicoll self-assigned this Jun 8, 2015
@snicoll
Copy link
Member

snicoll commented Jun 8, 2015

While the initial goal of this was to expose a way to shutdown the app it has moved to something more "admin-related": know if the app is ready, get the http port, etc.

Maybe we should move that back to o.s.boot and name it SpringApplicationAdminMXBean

Some keys should migrate as well then. And spring.application.* looks like a bad idea I think. Thoughts?

We have spring.context.lifecycle.enabled and spring.context.lifecycle.jmx-name

@snicoll snicoll removed their assignment Jun 9, 2015
@snicoll
Copy link
Member

snicoll commented Jun 10, 2015

The JMX name looks weird to me and there is still a spring.context.lifecycle.enabled property there.

@snicoll snicoll reopened this Jun 10, 2015
@snicoll snicoll self-assigned this Jun 10, 2015
@snicoll
Copy link
Member

snicoll commented Jun 10, 2015

This broke the maven plugin (start/stop). Looking at it

@mbert
Copy link

mbert commented Jun 11, 2015

Yesterday's changes fixed the issue, thank you!

@philwebb
Copy link
Member Author

@mbert Thanks for checking.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants