Skip to content

spring-boot-maven-plugin exclude doesn't filter sub-dependency #3426

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
zhanhb opened this issue Jul 6, 2015 · 3 comments
Closed

spring-boot-maven-plugin exclude doesn't filter sub-dependency #3426

zhanhb opened this issue Jul 6, 2015 · 3 comments
Labels
status: invalid An issue that we don't feel is valid

Comments

@zhanhb
Copy link
Contributor

zhanhb commented Jul 6, 2015

<project>
  <dependencies>
    <dependency>
      <groupId>com.mysema.querydsl</groupId>
      <artifactId>querydsl-apt</artifactId>
      <version>${querydsl.version}</version>
      <scope>provided</scope>
    </dependency>
  </dependencies>
  <build>
    <plugins>
      <plugin>
        <groupId>org.springframework.boot</groupId>
        <artifactId>spring-boot-maven-plugin</artifactId>
        <configuration>
          <excludes>
            <exclude>
              <groupId>com.mysema.querydsl</groupId>
              <artifactId>querydsl-apt</artifactId>
            </exclude>
          </excludes>
        </configuration>
      </plugin>
    </plugins>
  </build>
</project>

I will got a package with querydsl-codegen-3.6.4.jar in its lib-provided directory.

@philwebb
Copy link
Member

philwebb commented Jul 6, 2015

Excludes won't automatically apply to transitive dependencies, you'll need to list everything that you want removed.

@tenstriker
Copy link

Why not? In what scenario one would want child dependencies in their project when they don't want parents? Can there be a flag to exclude it conditionally at least?

@jjroldan1
Copy link

jjroldan1 commented Jan 17, 2017

Team, you may want to reconsider if the design is appropriate for many of the use cases of the plugin. The current behavior is not totally consistent when using ZIP and MODULE layouts in combination. I am going to use the layout factory feature coming in 1.5 (thanks @wilkinsona for the tip, I appreciate it) but still, I don't think you thought it through.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: invalid An issue that we don't feel is valid
Projects
None yet
Development

No branches or pull requests

4 participants