Skip to content

Correct the version of Checkstyle that's used #38746

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wilkinsona opened this issue Dec 12, 2023 · 1 comment
Closed

Correct the version of Checkstyle that's used #38746

wilkinsona opened this issue Dec 12, 2023 · 1 comment
Assignees
Labels
type: task A general task
Milestone

Comments

@wilkinsona
Copy link
Member

wilkinsona commented Dec 12, 2023

#37976 should have upgraded the build to use Checkstyle 10.12.4 but, looking at the XML report files, we appear to be using 9.3:

<?xml version="1.0" encoding="UTF-8"?>
<checkstyle version="9.3">
@wilkinsona wilkinsona added the type: task A general task label Dec 12, 2023
@wilkinsona wilkinsona added this to the 3.1.x milestone Dec 12, 2023
@wilkinsona wilkinsona self-assigned this Dec 12, 2023
@wilkinsona
Copy link
Member Author

wilkinsona commented Dec 12, 2023

Fixing this results in an NPE in one of our custom checks:

Caused by: java.lang.NullPointerException: Cannot invoke "io.spring.javaformat.checkstyle.check.SpringHeaderCheck$HeaderCheck.run(com.puppycrawl.tools.checkstyle.api.FileText, boolean)" because the return value of "io.spring.javaformat.checkstyle.check.SpringHeaderCheck.getCheck(java.io.File)" is null	
    at io.spring.javaformat.checkstyle.check.SpringHeaderCheck.processFiltered(SpringHeaderCheck.java:113)	
    at com.puppycrawl.tools.checkstyle.api.AbstractFileSetCheck.process(AbstractFileSetCheck.java:101)

This will have to be addressed in Spring Java Format.

@wilkinsona wilkinsona added the status: blocked An issue that's blocked on an external project change label Dec 12, 2023
@wilkinsona wilkinsona modified the milestones: 3.1.x, 3.1.8 Jan 11, 2024
@wilkinsona wilkinsona removed the status: blocked An issue that's blocked on an external project change label Feb 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: task A general task
Projects
None yet
Development

No branches or pull requests

1 participant