Skip to content

Upgrade to Json-smart 2.5.1 #40302

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wilkinsona opened this issue Apr 10, 2024 · 4 comments
Closed

Upgrade to Json-smart 2.5.1 #40302

wilkinsona opened this issue Apr 10, 2024 · 4 comments
Labels
type: dependency-upgrade A dependency upgrade
Milestone

Comments

@wilkinsona
Copy link
Member

No description provided.

@wilkinsona wilkinsona added the type: dependency-upgrade A dependency upgrade label Apr 10, 2024
@wilkinsona wilkinsona added this to the 3.2.5 milestone Apr 10, 2024
@ValentinBossi
Copy link

hi @wilkinsona
json-smart is in spring boot version 3.2.4 scoped as "compile" when i do mvn dependency:tree. it should be "test" right?

@wilkinsona
Copy link
Member Author

Spring Boot should only contribute it to your project's classpath through spring-boot-starter-test which you should declare in test scope.

This isn't really related to this upgrade and, as mentioned in the guidelines for contributing, we prefer to use GitHub issues only for bugs and enhancements. If you have any further questions, please follow up on Stack Overflow.

@ValentinBossi
Copy link

sorry i mean spring-boot-starter-test.
see:

[INFO] +- org.springframework.boot:spring-boot-starter-test:jar:3.2.4:test
[INFO] |  +- org.springframework.boot:spring-boot-test:jar:3.2.4:test
[INFO] |  +- org.springframework.boot:spring-boot-test-autoconfigure:jar:3.2.4:test
[INFO] |  +- com.jayway.jsonpath:json-path:jar:2.9.0:test
[INFO] |  +- jakarta.xml.bind:jakarta.xml.bind-api:jar:4.0.2:compile
[INFO] |  |  \- jakarta.activation:jakarta.activation-api:jar:2.1.3:compile
[INFO] |  +- net.minidev:json-smart:jar:2.5.0:compile
[INFO] |  |  \- net.minidev:accessors-smart:jar:2.5.0:compile
[INFO] |  |     \- org.ow2.asm:asm:jar:9.3:compile
[INFO] |  +- org.assertj:assertj-core:jar:3.24.2:test
[INFO] |  |  \- net.bytebuddy:byte-buddy:jar:1.14.12:test
[INFO] |  +- org.awaitility:awaitility:jar:4.2.0:test
[INFO] |  +- org.hamcrest:hamcrest:jar:2.2:test

@wilkinsona
Copy link
Member Author

It will be in test scope by default. Here's the typical output:

[INFO] \- org.springframework.boot:spring-boot-starter-test:jar:3.2.4:test
[INFO]    +- org.springframework.boot:spring-boot-test:jar:3.2.4:test
[INFO]    +- org.springframework.boot:spring-boot-test-autoconfigure:jar:3.2.4:test
[INFO]    +- com.jayway.jsonpath:json-path:jar:2.9.0:test
[INFO]    |  \- org.slf4j:slf4j-api:jar:2.0.12:compile
[INFO]    +- jakarta.xml.bind:jakarta.xml.bind-api:jar:4.0.2:test
[INFO]    |  \- jakarta.activation:jakarta.activation-api:jar:2.1.3:test
[INFO]    +- net.minidev:json-smart:jar:2.5.0:test
[INFO]    |  \- net.minidev:accessors-smart:jar:2.5.0:test
[INFO]    |     \- org.ow2.asm:asm:jar:9.3:test

Something else will be pulling it into compile scope. org.slf4j:slf4j-api:jar:2.0.12:compile is an example of this. It happens because it's also a dependency on spring-boot-starter that is in compile scope.

As I said above, please follow up on Stack Overflow. This is a Maven question and doesn't belong here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: dependency-upgrade A dependency upgrade
Projects
None yet
Development

No branches or pull requests

2 participants