Skip to content

Allow to auto configure ThreadPoolTaskScheduler/ThreadPoolTaskExecutor even if virtual threads enabled #42920

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
quaff opened this issue Oct 29, 2024 · 1 comment
Closed

Allow to auto configure ThreadPoolTaskScheduler/ThreadPoolTaskExecutor even if virtual threads enabled #42920

quaff opened this issue Oct 29, 2024 · 1 comment
Labels
status: superseded An issue that has been superseded by another

Comments

@quaff
Copy link
Contributor

quaff commented Oct 29, 2024

Currently Spring Boot auto configure SimpleAsyncTaskScheduler/SimpleAsyncTaskExecutor if virtual threads enabled, so far so good.
If #42918 get merged, I suggest to introduce configuration property that allow to auto configure ThreadPoolTaskScheduler/ThreadPoolTaskExecutor instead even if virtual threads enabled.
@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Oct 29, 2024
@bclozel
Copy link
Member

bclozel commented Oct 29, 2024

#42918 doesn't seem related, I guess you mean #42913. In any case we didn't even have time to consider the use case nor Juergen's comment, including the fact that pooling is breaking one of the best practices of virtual threads.

I've created #42921 to start discussing that with the team.

@bclozel bclozel closed this as not planned Won't fix, can't repro, duplicate, stale Oct 29, 2024
@bclozel bclozel added status: superseded An issue that has been superseded by another and removed status: waiting-for-triage An issue we've not yet triaged labels Oct 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
status: superseded An issue that has been superseded by another
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@bclozel @quaff @spring-projects-issues