Skip to content

spring-boot-maven-plugin sets imagePlatform even if it's empty #43702

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
joansigh opened this issue Jan 6, 2025 · 3 comments
Closed

spring-boot-maven-plugin sets imagePlatform even if it's empty #43702

joansigh opened this issue Jan 6, 2025 · 3 comments

Comments

@joansigh
Copy link

joansigh commented Jan 6, 2025

"A Docker image cannot be built with the spring-boot-maven-plugin:3.4.0 if Docker API version is less than 1.41. In particular, a Spring Boot project builds are failing in Bitbucket pipelines when no 'imagePlatform' option configured for the project with the following error

Using an empty tag in the pom.xml doesn't help as Maven, most probably, assigns an empty string to the corresp. Java property.

The proposed fix is to check the config property for both null and empty string values."

The above is from a pull request that I saw. The question that I was unable to get an answer to was, why would someone be using an API version less than 1.41?

Also in the pull request, the poster says that in particular, Spring Boot project builds are failing when no imagePlatform option is configured. I'm not sure in what scenarios someone would not configure the imagePlatform option. By default, in Spring Boot project builds, is the imagePlatform option not configured? Are people specifically putting an empty tag?

The pull request mentions that due to the empty tag, an empty string is assigned to the tag.

a91745a

Due to the code change, empty strings will now return False rather than True. What effect does this change have on Docker, spring-boot-maven, and the general workflow/environment that the pull request is operating in as a whole?

@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Jan 6, 2025
@philwebb
Copy link
Member

philwebb commented Jan 6, 2025

The PR in question is #43424

@johnasiano I'm not sure I understand what's driving your questions. Are you facing an issue with the fix? I don't know why someone would choose to run a version less than 1.41, but we want to support them if they choose to do so.

@philwebb philwebb added the status: waiting-for-feedback We need additional information before we can continue label Jan 6, 2025
@spring-projects-issues
Copy link
Collaborator

If you would like us to look at this issue, please provide the requested information. If the information is not provided within the next 7 days this issue will be closed.

@spring-projects-issues spring-projects-issues added the status: feedback-reminder We've sent a reminder that we need additional information before we can continue label Jan 13, 2025
@spring-projects-issues
Copy link
Collaborator

Closing due to lack of requested feedback. If you would like us to look at this issue, please provide the requested information and we will re-open the issue.

@spring-projects-issues spring-projects-issues closed this as not planned Won't fix, can't repro, duplicate, stale Jan 20, 2025
@spring-projects-issues spring-projects-issues removed status: waiting-for-feedback We need additional information before we can continue status: feedback-reminder We've sent a reminder that we need additional information before we can continue status: waiting-for-triage An issue we've not yet triaged labels Jan 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants