-
Notifications
You must be signed in to change notification settings - Fork 41.2k
Clarify the situation with support for Prometheus PushGateway and the deprecated simpleclient #44392
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
We've added support in Spring Boot 3.5. That won't be back ported to 3.4 as we consider it to be a new feature and we don't back port new features to maintenance branches. We can use this issue to clarify the documentation. |
@wilkinsona Thanks for your reply. I see the milestone has been set to 3.3.x, but I think this should be 3.4.x? |
It's applicable to 3.3.x as well because its documentation contains the same note. |
Hi @wilkinsona, may I have this issue assigned to me please? |
Thanks for the offer, @thecooldrop, but we've found that documentation updates like this are better handled by the core team. |
Spring Boot 3.4's Prometheus documentation says:
The Prometheus 1.x client added PushGateway support in version 1.3.0, so the blocker mentioned above is gone. I think it would be good to update this documentation note to reflect that.
Also, I don't believe the PushGateway support in the Prometheus 1.x client gets auto-configured yet, so I think this still needs to be added in Spring Boot 3.4?
The text was updated successfully, but these errors were encountered: