Skip to content

Make in-memory database tests default to using random name #7102

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
philwebb opened this issue Oct 5, 2016 · 4 comments
Closed

Make in-memory database tests default to using random name #7102

philwebb opened this issue Oct 5, 2016 · 4 comments
Labels
status: declined A suggestion or change that we don't feel we should currently apply

Comments

@philwebb
Copy link
Member

philwebb commented Oct 5, 2016

See #7004 for background.
@philwebb philwebb added this to the 1.5.0 milestone Oct 5, 2016
@snicoll snicoll mentioned this issue Oct 6, 2016
Closed
@snicoll snicoll modified the milestones: 1.5.0 RC1, 1.5.0 Nov 24, 2016
@snicoll
Copy link
Member

snicoll commented Nov 24, 2016

@philwebb what did you have in mind for this. Do I understand we want to override the property when our test annotations are used? Somewhere in SpringBootTestContextBootstrapper#processPropertySourceProperties maybe?

@philwebb
Copy link
Member Author

I didn't really have anything in mind, I just added the bug when #7004 was raised so we didn't forget about it. Perhaps we can add something to AutoConfigureTestDatabase?

@snicoll
Copy link
Member

snicoll commented Nov 30, 2016

Perhaps we can add something to AutoConfigureTestDatabase?

It's already done (#7473) and it isn't the same thing IMO. If we want this to be transparent, it should apply regardless of the test slice. Arguably an integration test should have a fresh database per cached context as well. IMO the best place is the one I've referenced above but I am happy to be proven wrong.

@snicoll snicoll added the for: team-attention An issue we'd like other members of the team to review label Nov 30, 2016
@snicoll
Copy link
Member

snicoll commented Nov 30, 2016

Let's stick with #7473 and let users enable that setting for integration tests as we need a way for them to opt-in.

@snicoll snicoll closed this as completed Nov 30, 2016
@snicoll snicoll added status: declined A suggestion or change that we don't feel we should currently apply and removed for: team-attention An issue we'd like other members of the team to review labels Nov 30, 2016
@snicoll snicoll removed this from the 1.5.0 RC1 milestone Nov 30, 2016
@odrotbohm odrotbohm mentioned this issue May 8, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
status: declined A suggestion or change that we don't feel we should currently apply
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@snicoll @philwebb