Skip to content

Commit 694df79

Browse files
committed
Fix cache clear/evict to use collections part 2.
Closes #1369.
1 parent d0ff616 commit 694df79

File tree

2 files changed

+10
-15
lines changed

2 files changed

+10
-15
lines changed

src/main/java/org/springframework/data/couchbase/cache/DefaultCouchbaseCacheWriter.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -105,7 +105,7 @@ public boolean remove(final String collectionName, final String key) {
105105
@Override
106106
public long clear(final String collectionName, final String pattern) {
107107
QueryResult result = clientFactory.getScope().query(
108-
"DELETE FROM `" + collectionName + "` where meta().id LIKE $pattern",
108+
"DELETE FROM `" + getCollection(collectionName).name() + "` where meta().id LIKE $pattern",
109109
queryOptions().scanConsistency(REQUEST_PLUS).metrics(true).parameters(JsonObject.create().put("pattern", pattern + "%")));
110110
return result.metaData().metrics().map(QueryMetrics::mutationCount).orElse(0L);
111111
}

src/test/java/org/springframework/data/couchbase/cache/CouchbaseCacheIntegrationTests.java

Lines changed: 9 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -57,7 +57,6 @@ public void beforeEach() {
5757
super.beforeEach();
5858
cache = CouchbaseCacheManager.create(couchbaseTemplate.getCouchbaseClientFactory()).createCouchbaseCache("myCache",
5959
CouchbaseCacheConfiguration.defaultCacheConfig());
60-
clear(cache);
6160
ApplicationContext ac = new AnnotationConfigApplicationContext(Config.class);
6261
cacheManager = ac.getBean(CouchbaseCacheManager.class);
6362
userRepository = ac.getBean(UserRepository.class);
@@ -66,17 +65,11 @@ public void beforeEach() {
6665
@AfterEach
6766
@Override
6867
public void afterEach() {
69-
clear(cache);
68+
cache.clear();
7069
super.afterEach();
7170
}
7271

73-
private void clear(CouchbaseCache c) {
74-
couchbaseTemplate.getCouchbaseClientFactory().getCluster().query("SELECT count(*) from `" + bucketName() + "`",
75-
QueryOptions.queryOptions().scanConsistency(REQUEST_PLUS));
76-
c.clear();
77-
couchbaseTemplate.getCouchbaseClientFactory().getCluster().query("SELECT count(*) from `" + bucketName() + "`",
78-
QueryOptions.queryOptions().scanConsistency(REQUEST_PLUS));
79-
}
72+
8073

8174
@Test
8275
void cachePutGet() {
@@ -109,17 +102,19 @@ void cacheEvict() {
109102
cache.put(user1.getId(), user1); // put user1
110103
cache.put(user2.getId(), user2); // put user2
111104
cache.evict(user1.getId()); // evict user1
105+
assertNull(cache.get(user1.getId())); // get user1 -> not present
112106
assertEquals(user2, cache.get(user2.getId()).get()); // get user2 -> present
113107
}
114108

115109
@Test
116-
void cacheHitMiss() {
110+
void cacheClear() {
117111
CacheUser user1 = new CacheUser(UUID.randomUUID().toString(), "first1", "last1");
118112
CacheUser user2 = new CacheUser(UUID.randomUUID().toString(), "first2", "last2");
119-
assertNull(cache.get(user2.getId())); // get user2 -> cacheMiss
120-
cache.put(user1.getId(), null); // cache a null
121-
assertNotNull(cache.get(user1.getId())); // cacheHit null
122-
assertNull(cache.get(user1.getId()).get()); // fetch cached null
113+
cache.put(user1.getId(), user1); // put user1
114+
cache.put(user2.getId(), user2); // put user2
115+
cache.clear();
116+
assertNull(cache.get(user1.getId())); // get user1 -> not present
117+
assertNull(cache.get(user2.getId())); // get user2 -> not present
123118
}
124119

125120
@Test

0 commit comments

Comments
 (0)