Skip to content

Commit 3bc01a4

Browse files
author
Farid Faoudi
authored
ReactiveElasticsearchClient should use the same request parameters as non reactive code.
Original Pull Request #1703 Closes #1658
1 parent 1c549b7 commit 3bc01a4

File tree

5 files changed

+470
-56
lines changed

5 files changed

+470
-56
lines changed

Diff for: src/main/java/org/springframework/data/elasticsearch/client/reactive/DefaultReactiveElasticsearchClient.java

+43-12
Original file line numberDiff line numberDiff line change
@@ -48,14 +48,9 @@
4848
import org.elasticsearch.action.admin.indices.alias.IndicesAliasesRequest;
4949
import org.elasticsearch.action.admin.indices.alias.get.GetAliasesRequest;
5050
import org.elasticsearch.action.admin.indices.close.CloseIndexRequest;
51-
import org.elasticsearch.action.admin.indices.create.CreateIndexRequest;
5251
import org.elasticsearch.action.admin.indices.delete.DeleteIndexRequest;
5352
import org.elasticsearch.action.admin.indices.flush.FlushRequest;
5453
import org.elasticsearch.action.admin.indices.flush.FlushResponse;
55-
import org.elasticsearch.action.admin.indices.get.GetIndexRequest;
56-
import org.elasticsearch.action.admin.indices.mapping.get.GetMappingsRequest;
57-
import org.elasticsearch.action.admin.indices.mapping.get.GetMappingsResponse;
58-
import org.elasticsearch.action.admin.indices.mapping.put.PutMappingRequest;
5954
import org.elasticsearch.action.admin.indices.open.OpenIndexRequest;
6055
import org.elasticsearch.action.admin.indices.refresh.RefreshRequest;
6156
import org.elasticsearch.action.admin.indices.refresh.RefreshResponse;
@@ -84,13 +79,18 @@
8479
import org.elasticsearch.action.update.UpdateResponse;
8580
import org.elasticsearch.client.GetAliasesResponse;
8681
import org.elasticsearch.client.Request;
82+
import org.elasticsearch.client.indices.CreateIndexRequest;
8783
import org.elasticsearch.client.indices.GetFieldMappingsRequest;
8884
import org.elasticsearch.client.indices.GetFieldMappingsResponse;
85+
import org.elasticsearch.client.indices.GetIndexRequest;
8986
import org.elasticsearch.client.indices.GetIndexResponse;
9087
import org.elasticsearch.client.indices.GetIndexTemplatesRequest;
9188
import org.elasticsearch.client.indices.GetIndexTemplatesResponse;
89+
import org.elasticsearch.client.indices.GetMappingsRequest;
90+
import org.elasticsearch.client.indices.GetMappingsResponse;
9291
import org.elasticsearch.client.indices.IndexTemplatesExistRequest;
9392
import org.elasticsearch.client.indices.PutIndexTemplateRequest;
93+
import org.elasticsearch.client.indices.PutMappingRequest;
9494
import org.elasticsearch.common.unit.TimeValue;
9595
import org.elasticsearch.common.xcontent.DeprecationHandler;
9696
import org.elasticsearch.common.xcontent.NamedXContentRegistry;
@@ -646,13 +646,22 @@ private RequestBodySpec sendRequest(WebClient webClient, String logId, Request r
646646

647647
// region indices operations
648648
@Override
649-
public Mono<Boolean> createIndex(HttpHeaders headers, CreateIndexRequest createIndexRequest) {
649+
public Mono<Boolean> createIndex(HttpHeaders headers,
650+
org.elasticsearch.action.admin.indices.create.CreateIndexRequest createIndexRequest) {
650651

651652
return sendRequest(createIndexRequest, requestCreator.indexCreate(), AcknowledgedResponse.class, headers) //
652653
.map(AcknowledgedResponse::isAcknowledged) //
653654
.next();
654655
}
655656

657+
@Override
658+
public Mono<Boolean> createIndex(HttpHeaders headers, CreateIndexRequest createIndexRequest) {
659+
660+
return sendRequest(createIndexRequest, requestCreator.createIndexRequest(), AcknowledgedResponse.class, headers) //
661+
.map(AcknowledgedResponse::isAcknowledged) //
662+
.next();
663+
}
664+
656665
@Override
657666
public Mono<Void> closeIndex(HttpHeaders headers, CloseIndexRequest closeIndexRequest) {
658667

@@ -661,14 +670,21 @@ public Mono<Void> closeIndex(HttpHeaders headers, CloseIndexRequest closeIndexRe
661670
}
662671

663672
@Override
664-
public Mono<Boolean> existsIndex(HttpHeaders headers, GetIndexRequest request) {
673+
public Mono<Boolean> existsIndex(HttpHeaders headers, org.elasticsearch.action.admin.indices.get.GetIndexRequest request) {
665674

666675
return sendRequest(request, requestCreator.indexExists(), RawActionResponse.class, headers) //
667676
.flatMap(response -> response.releaseBody().thenReturn(response.statusCode().is2xxSuccessful())) //
668677
.next();
669678
}
670679

671-
@Override
680+
@Override
681+
public Mono<Boolean> existsIndex(HttpHeaders headers, GetIndexRequest request) {
682+
return sendRequest(request, requestCreator.indexExistsRequest(), RawActionResponse.class, headers) //
683+
.flatMap(response -> response.releaseBody().thenReturn(response.statusCode().is2xxSuccessful())) //
684+
.next();
685+
}
686+
687+
@Override
672688
public Mono<Boolean> deleteIndex(HttpHeaders headers, DeleteIndexRequest request) {
673689

674690
return sendRequest(request, requestCreator.indexDelete(), AcknowledgedResponse.class, headers) //
@@ -683,9 +699,17 @@ public Mono<Void> flushIndex(HttpHeaders headers, FlushRequest flushRequest) {
683699
.then();
684700
}
685701

702+
@Override
703+
public Mono<org.elasticsearch.action.admin.indices.mapping.get.GetMappingsResponse> getMapping(HttpHeaders headers,
704+
org.elasticsearch.action.admin.indices.mapping.get.GetMappingsRequest getMappingsRequest) {
705+
return sendRequest(getMappingsRequest, requestCreator.getMapping(),
706+
org.elasticsearch.action.admin.indices.mapping.get.GetMappingsResponse.class, headers).next();
707+
}
708+
686709
@Override
687710
public Mono<GetMappingsResponse> getMapping(HttpHeaders headers, GetMappingsRequest getMappingsRequest) {
688-
return sendRequest(getMappingsRequest, requestCreator.getMapping(), GetMappingsResponse.class, headers).next();
711+
return sendRequest(getMappingsRequest, requestCreator.getMappingRequest(), GetMappingsResponse.class, headers) //
712+
.next();
689713
}
690714

691715
@Override
@@ -701,13 +725,21 @@ public Mono<GetSettingsResponse> getSettings(HttpHeaders headers, GetSettingsReq
701725
}
702726

703727
@Override
704-
public Mono<Boolean> putMapping(HttpHeaders headers, PutMappingRequest putMappingRequest) {
728+
public Mono<Boolean> putMapping(HttpHeaders headers,
729+
org.elasticsearch.action.admin.indices.mapping.put.PutMappingRequest putMappingRequest) {
705730

706731
return sendRequest(putMappingRequest, requestCreator.putMapping(), AcknowledgedResponse.class, headers) //
707732
.map(AcknowledgedResponse::isAcknowledged) //
708733
.next();
709734
}
710735

736+
@Override
737+
public Mono<Boolean> putMapping(HttpHeaders headers, PutMappingRequest putMappingRequest) {
738+
return sendRequest(putMappingRequest, requestCreator.putMappingRequest(), AcknowledgedResponse.class, headers) //
739+
.map(AcknowledgedResponse::isAcknowledged) //
740+
.next();
741+
}
742+
711743
@Override
712744
public Mono<Void> openIndex(HttpHeaders headers, OpenIndexRequest request) {
713745

@@ -760,8 +792,7 @@ public Mono<Boolean> deleteTemplate(HttpHeaders headers, DeleteIndexTemplateRequ
760792
}
761793

762794
@Override
763-
public Mono<GetIndexResponse> getIndex(HttpHeaders headers,
764-
org.elasticsearch.client.indices.GetIndexRequest getIndexRequest) {
795+
public Mono<GetIndexResponse> getIndex(HttpHeaders headers, GetIndexRequest getIndexRequest) {
765796
return sendRequest(getIndexRequest, requestCreator.getIndex(), GetIndexResponse.class, headers).next();
766797
}
767798

0 commit comments

Comments
 (0)