Skip to content

Commit 1d99afa

Browse files
quaffmp911de
authored andcommitted
Verify modifying methods are annotated with @Transactional
Closes #3188 Original pull request: #3194
1 parent af27a15 commit 1d99afa

File tree

1 file changed

+22
-0
lines changed

1 file changed

+22
-0
lines changed

Diff for: spring-data-jpa/src/test/java/org/springframework/data/jpa/repository/support/SimpleJpaRepositoryUnitTests.java

+22
Original file line numberDiff line numberDiff line change
@@ -16,6 +16,7 @@
1616
package org.springframework.data.jpa.repository.support;
1717

1818
import static java.util.Collections.singletonMap;
19+
import static org.assertj.core.api.Assertions.assertThat;
1920
import static org.assertj.core.api.Assertions.assertThatNoException;
2021
import static org.mockito.Mockito.any;
2122
import static org.mockito.Mockito.never;
@@ -31,12 +32,18 @@
3132
import jakarta.persistence.criteria.CriteriaBuilder;
3233
import jakarta.persistence.criteria.CriteriaQuery;
3334

35+
import java.lang.reflect.Method;
36+
import java.lang.reflect.Modifier;
3437
import java.util.Arrays;
38+
import java.util.List;
3539
import java.util.Optional;
40+
import java.util.stream.Stream;
3641

3742
import org.junit.jupiter.api.BeforeEach;
3843
import org.junit.jupiter.api.Test;
3944
import org.junit.jupiter.api.extension.ExtendWith;
45+
import org.junit.jupiter.params.ParameterizedTest;
46+
import org.junit.jupiter.params.provider.MethodSource;
4047
import org.mockito.Mock;
4148
import org.mockito.junit.jupiter.MockitoExtension;
4249
import org.mockito.junit.jupiter.MockitoSettings;
@@ -45,6 +52,7 @@
4552
import org.springframework.data.jpa.domain.sample.User;
4653
import org.springframework.data.jpa.repository.EntityGraph.EntityGraphType;
4754
import org.springframework.data.repository.CrudRepository;
55+
import org.springframework.transaction.annotation.Transactional;
4856

4957
/**
5058
* Unit tests for {@link SimpleJpaRepository}.
@@ -54,6 +62,7 @@
5462
* @author Mark Paluch
5563
* @author Jens Schauder
5664
* @author Greg Turnquist
65+
* @author Yanming Zhou
5766
*/
5867
@ExtendWith(MockitoExtension.class)
5968
@MockitoSettings(strictness = Strictness.LENIENT)
@@ -216,4 +225,17 @@ void applyQueryHintsToCountQueriesForSpecificationPageables() {
216225

217226
verify(metadata).getQueryHintsForCount();
218227
}
228+
229+
@ParameterizedTest // GH-3188
230+
@MethodSource("modifyingMethods")
231+
void checkTransactionalAnnotation(Method method) {
232+
Transactional transactional = method.getAnnotation(Transactional.class);
233+
assertThat(transactional).as("Method [%s] should be annotated with @Transactional", method).isNotNull();
234+
assertThat(transactional.readOnly()).as("Method [%s] should not be annotated with @Transactional(readOnly = true)", method).isFalse();
235+
}
236+
237+
static List<Method> modifyingMethods() {
238+
return Stream.of(SimpleJpaRepository.class.getDeclaredMethods()).filter(method -> Modifier.isPublic(method.getModifiers()) &&
239+
!method.isBridge() && (method.getName().startsWith("delete") || method.getName().startsWith("save"))).toList();
240+
}
219241
}

0 commit comments

Comments
 (0)