Switch default to Predicate-based QueryEngine.

See: #565

Author: christophstrobl

Diff for: src/main/java/org/springframework/data/keyvalue/core/AbstractKeyValueAdapter.java

@@ -46,7 +46,7 @@ protected AbstractKeyValueAdapter() {
 	 * @since 3.1.10
 	 */
 	protected AbstractKeyValueAdapter(SortAccessor<Comparator<?>> sortAccessor) {
-		this(new SpelQueryEngine(sortAccessor));
+		this(new PredicateQueryEngine(sortAccessor));
 	}
 
 	/**
@@ -56,7 +56,7 @@ protected AbstractKeyValueAdapter(SortAccessor<Comparator<?>> sortAccessor) {
 	 */
 	protected AbstractKeyValueAdapter(@Nullable QueryEngine<? extends KeyValueAdapter, ?, ?> engine) {
 
-		this.engine = engine != null ? engine : new SpelQueryEngine();
+		this.engine = engine != null ? engine : new PredicateQueryEngine();
 		this.engine.registerAdapter(this);
 	}
 

Diff for: src/main/java/org/springframework/data/keyvalue/repository/support/KeyValueRepositoryFactory.java

@@ -26,7 +26,7 @@
 import org.springframework.dao.InvalidDataAccessApiUsageException;
 import org.springframework.data.keyvalue.core.KeyValueOperations;
 import org.springframework.data.keyvalue.repository.query.KeyValuePartTreeQuery;
-import org.springframework.data.keyvalue.repository.query.SpelQueryCreator;
+import org.springframework.data.keyvalue.repository.query.PredicateQueryCreator;
 import org.springframework.data.mapping.PersistentEntity;
 import org.springframework.data.mapping.context.MappingContext;
 import org.springframework.data.projection.ProjectionFactory;
@@ -58,7 +58,7 @@
  */
 public class KeyValueRepositoryFactory extends RepositoryFactorySupport {
 
-	private static final Class<SpelQueryCreator> DEFAULT_QUERY_CREATOR = SpelQueryCreator.class;
+	private static final Class<PredicateQueryCreator> DEFAULT_QUERY_CREATOR = PredicateQueryCreator.class;
 
 	private final KeyValueOperations keyValueOperations;
 	private final MappingContext<?, ?> context;

Diff for: src/main/java/org/springframework/data/map/repository/config/EnableMapRepositories.java

@@ -32,8 +32,8 @@
 import org.springframework.data.keyvalue.core.KeyValueTemplate;
 import org.springframework.data.keyvalue.core.SortAccessor;
 import org.springframework.data.keyvalue.repository.config.QueryCreatorType;
-import org.springframework.data.keyvalue.repository.query.CachingKeyValuePartTreeQuery;
-import org.springframework.data.keyvalue.repository.query.SpelQueryCreator;
+import org.springframework.data.keyvalue.repository.query.KeyValuePartTreeQuery;
+import org.springframework.data.keyvalue.repository.query.PredicateQueryCreator;
 import org.springframework.data.keyvalue.repository.support.KeyValueRepositoryFactoryBean;
 import org.springframework.data.repository.config.DefaultRepositoryBaseClass;
 import org.springframework.data.repository.query.QueryLookupStrategy;
@@ -51,7 +51,7 @@
 @Documented
 @Inherited
 @Import(MapRepositoriesRegistrar.class)
-@QueryCreatorType(value = SpelQueryCreator.class, repositoryQueryType = CachingKeyValuePartTreeQuery.class)
+@QueryCreatorType(value = PredicateQueryCreator.class, repositoryQueryType = KeyValuePartTreeQuery.class)
 public @interface EnableMapRepositories {
 
 	/**

Diff for: src/test/java/org/springframework/data/keyvalue/core/KeyValueTemplateTests.java

@@ -23,6 +23,7 @@
 import java.lang.annotation.RetentionPolicy;
 import java.lang.annotation.Target;
 import java.util.List;
+import java.util.function.Predicate;
 
 import org.junit.jupiter.api.AfterEach;
 import org.junit.jupiter.api.BeforeEach;
@@ -48,7 +49,8 @@ class KeyValueTemplateTests {
 	private static final Bar BAR_ONE = new Bar("one");
 	private static final ClassWithTypeAlias ALIASED = new ClassWithTypeAlias("super");
 	private static final SubclassOfAliasedType SUBCLASS_OF_ALIASED = new SubclassOfAliasedType("sub");
-	private static final KeyValueQuery<String> STRING_QUERY = new KeyValueQuery<>("foo == 'two'");
+
+	private static final KeyValueQuery<Predicate<Foo>> STRING_QUERY = new KeyValueQuery<>((Predicate<Foo>) foo -> foo.getFoo().equals("two"));
 
 	private KeyValueTemplate operations;
 

Diff for: src/test/java/org/springframework/data/map/CachingQuerySimpleKeyValueRepositoryUnitTests.java

@@ -15,23 +15,26 @@
  */
 package org.springframework.data.map;
 
+import org.junit.jupiter.api.Disabled;
 import org.springframework.data.keyvalue.core.KeyValueOperations;
 import org.springframework.data.keyvalue.repository.query.CachingKeyValuePartTreeQuery;
+import org.springframework.data.keyvalue.repository.query.PredicateQueryCreator;
 import org.springframework.data.keyvalue.repository.query.SpelQueryCreator;
 import org.springframework.data.keyvalue.repository.support.KeyValueRepositoryFactory;
 import org.springframework.data.keyvalue.repository.support.SimpleKeyValueRepository;
 
 /**
  * Unit tests for {@link SimpleKeyValueRepository} using {@link CachingKeyValuePartTreeQuery} and
- * {@link SpelQueryCreator}.
+ * {@link PredicateQueryCreator}.
  *
  * @author Mark Paluch
  * @author Christoph Strobl
  */
+@Disabled
 public class CachingQuerySimpleKeyValueRepositoryUnitTests extends SimpleKeyValueRepositoryUnitTests {
 
 	@Override
 	protected KeyValueRepositoryFactory createKeyValueRepositoryFactory(KeyValueOperations operations) {
-		return new KeyValueRepositoryFactory(operations, SpelQueryCreator.class, CachingKeyValuePartTreeQuery.class);
+		return new KeyValueRepositoryFactory(operations, PredicateQueryCreator.class, CachingKeyValuePartTreeQuery.class);
 	}
 }