Skip to content

Commit f76c8b7

Browse files
committed
Polishing.
Extract docker credentials into properties file. See #417
1 parent 69af1ee commit f76c8b7

File tree

2 files changed

+13
-9
lines changed

2 files changed

+13
-9
lines changed

Jenkinsfile

+5-5
Original file line numberDiff line numberDiff line change
@@ -34,7 +34,7 @@ pipeline {
3434
}
3535
steps {
3636
script {
37-
docker.withRegistry('', 'hub.docker.com-springbuildmaster') {
37+
docker.withRegistry(p['docker.registry'], p['docker.credentials']) {
3838
docker.image(p['docker.java.main.image']).inside(p['docker.java.inside.basic']) {
3939
sh 'MAVEN_OPTS="-Duser.name=jenkins -Duser.home=/tmp/jenkins-home" ./mvnw -s settings.xml clean dependency:list test -Dsort -U -B'
4040
}
@@ -61,7 +61,7 @@ pipeline {
6161
}
6262
steps {
6363
script {
64-
docker.withRegistry('', 'hub.docker.com-springbuildmaster') {
64+
docker.withRegistry(p['docker.registry'], p['docker.credentials']) {
6565
docker.image(p['docker.java.next.image']).inside(p['docker.java.inside.basic']) {
6666
sh 'MAVEN_OPTS="-Duser.name=jenkins -Duser.home=/tmp/jenkins-home" ./mvnw -s settings.xml -Pjava11 clean dependency:list test -Dsort -U -B'
6767
}
@@ -80,7 +80,7 @@ pipeline {
8080
}
8181
steps {
8282
script {
83-
docker.withRegistry('', 'hub.docker.com-springbuildmaster') {
83+
docker.withRegistry(p['docker.registry'], p['docker.credentials']) {
8484
docker.image(p['docker.java.15.image']).inside(p['docker.java.inside.basic']) {
8585
sh 'MAVEN_OPTS="-Duser.name=jenkins -Duser.home=/tmp/jenkins-home" ./mvnw -s settings.xml -Pjava11 clean dependency:list test -Dsort -U -B'
8686
}
@@ -109,7 +109,7 @@ pipeline {
109109

110110
steps {
111111
script {
112-
docker.withRegistry('', 'hub.docker.com-springbuildmaster') {
112+
docker.withRegistry(p['docker.registry'], p['docker.credentials']) {
113113
docker.image(p['docker.java.main.image']).inside(p['docker.java.inside.basic']) {
114114
sh 'MAVEN_OPTS="-Duser.name=jenkins -Duser.home=/tmp/jenkins-home" ./mvnw -s settings.xml -Pci,artifactory ' +
115115
'-Dartifactory.server=https://repo.spring.io ' +
@@ -139,7 +139,7 @@ pipeline {
139139

140140
steps {
141141
script {
142-
docker.withRegistry('', 'hub.docker.com-springbuildmaster') {
142+
docker.withRegistry(p['docker.registry'], p['docker.credentials']) {
143143
docker.image('adoptopenjdk/openjdk8:latest').inside('-v $HOME:/tmp/jenkins-home') {
144144
sh 'MAVEN_OPTS="-Duser.name=jenkins -Duser.home=/tmp/jenkins-home" ./mvnw -s settings.xml -Pci,distribute ' +
145145
'-Dartifactory.server=https://repo.spring.io ' +

ci/pipeline.properties

+8-4
Original file line numberDiff line numberDiff line change
@@ -1,12 +1,12 @@
11
# Java versions
22
java.main.tag=8u312-b07-jdk
3-
java.next.tag=11.0.13_8-jdk
4-
java.lts.tag=17.0.1_12-jdk
3+
java.11.tag=11.0.13_8-jdk
4+
java.15.tag=15.0.2_7-jdk-hotspot
55

66
# Docker container images - standard
77
docker.java.main.image=eclipse-temurin:${java.main.tag}
8-
docker.java.next.image=eclipse-temurin:${java.next.tag}
9-
docker.java.lts.image=eclipse-temurin:${java.lts.tag}
8+
docker.java.11.image=eclipse-temurin:${java.11.tag}
9+
docker.java.15.image=adoptopenjdk:${java.15.tag}
1010

1111
# Supported versions of MongoDB
1212
docker.mongodb.4.0.version=4.0.23
@@ -22,3 +22,7 @@ docker.cassandra.3.version=3.11.10
2222
# Docker environment settings
2323
docker.java.inside.basic=-v $HOME:/tmp/jenkins-home
2424
docker.java.inside.docker=-u root -v /var/run/docker.sock:/var/run/docker.sock -v /usr/bin/docker:/usr/bin/docker -v $HOME:/tmp/jenkins-home
25+
26+
# Credentials
27+
docker.registry=
28+
docker.credentials=hub.docker.com-springbuildmaster

0 commit comments

Comments
 (0)