Skip to content

Commit 8843328

Browse files
schauderschauder
committed
Unifying GitHub references to GH-nnn.
Original pull request #903 See #578
1 parent 377d841 commit 8843328

12 files changed

+43
-43
lines changed

Diff for: ‎spring-data-jdbc/src/test/java/org/springframework/data/jdbc/core/convert/BasicJdbcConverterUnitTests.java

+1-1
Original file line numberDiff line numberDiff line change
@@ -131,7 +131,7 @@ void conversionOfDateLikeValueAndBackYieldsOriginalValue() {
131131

132132
}
133133

134-
@Test // #945
134+
@Test // GH-945
135135
void conversionOfPrimitiveArrays() {
136136

137137
int[] ints = { 1, 2, 3, 4, 5 };

Diff for: ‎spring-data-jdbc/src/test/java/org/springframework/data/jdbc/core/convert/DefaultDataAccessStrategyUnitTests.java

+2-2
Original file line numberDiff line numberDiff line change
@@ -193,7 +193,7 @@ public void considersConfiguredWriteConverterForIdValueObjectsWhichReferencedInO
193193
assertThat(paramSourceCaptor.getValue().getValue("DUMMYENTITYROOT")).isEqualTo(rawId);
194194
}
195195

196-
@Test // #933
196+
@Test // GH-933
197197
public void insertWithDefinedIdDoesNotRetrieveGeneratedKeys() {
198198

199199
Object generatedId = accessStrategy.insert(new DummyEntity(ORIGINAL_ID), DummyEntity.class, Identifier.from(additionalParameters));
@@ -204,7 +204,7 @@ public void insertWithDefinedIdDoesNotRetrieveGeneratedKeys() {
204204
paramSourceCaptor.capture());
205205
}
206206

207-
@Test // #933
207+
@Test // GH-933
208208
public void insertWithUndefinedIdRetrievesGeneratedKeys() {
209209

210210
when(namedJdbcOperations.update(any(), any(), any()))

Diff for: ‎spring-data-jdbc/src/test/java/org/springframework/data/jdbc/core/convert/JdbcCustomConversionsUnitTests.java

+1-1
Original file line numberDiff line numberDiff line change
@@ -27,7 +27,7 @@
2727
*/
2828
class JdbcCustomConversionsUnitTests {
2929

30-
@Test // #937
30+
@Test // GH-937
3131
void registersNonDateDefaultConverter() {
3232

3333
JdbcCustomConversions conversions = new JdbcCustomConversions();

Diff for: ‎spring-data-jdbc/src/test/java/org/springframework/data/jdbc/core/dialect/JdbcDb2DialectUnitTests.java

+1-1
Original file line numberDiff line numberDiff line change
@@ -32,7 +32,7 @@
3232
*/
3333
class JdbcDb2DialectUnitTests {
3434

35-
@Test // #974
35+
@Test // GH-974
3636
void testCustomConversions() {
3737

3838
JdbcCustomConversions customConversions = new JdbcCustomConversions(

Diff for: ‎spring-data-jdbc/src/test/java/org/springframework/data/jdbc/core/dialect/JdbcMySqlDialectUnitTests.java

+1-1
Original file line numberDiff line numberDiff line change
@@ -32,7 +32,7 @@
3232
*/
3333
class JdbcMySqlDialectUnitTests {
3434

35-
@Test // #974
35+
@Test // GH-974
3636
void testCustomConversions() {
3737

3838
JdbcCustomConversions customConversions = new JdbcCustomConversions(

Diff for: ‎spring-data-jdbc/src/test/java/org/springframework/data/jdbc/core/mapping/BasicJdbcPersistentPropertyUnitTests.java

+1-1
Original file line numberDiff line numberDiff line change
@@ -96,7 +96,7 @@ public void detectsKeyColumnOverrideNameFromMappedCollectionAnnotation() {
9696
assertThat(listProperty.getReverseColumnName(path)).isEqualTo(quoted("override_id"));
9797
}
9898

99-
@Test // #938
99+
@Test // GH-938
100100
void considersAggregateReferenceAnAssociation() {
101101

102102
RelationalPersistentEntity<?> entity = context.getRequiredPersistentEntity(DummyEntity.class);

Diff for: ‎spring-data-jdbc/src/test/java/org/springframework/data/jdbc/repository/JdbcRepositoryIntegrationTests.java

+8-8
Original file line numberDiff line numberDiff line change
@@ -402,7 +402,7 @@ public void countByQueryDerivation() {
402402
assertThat(repository.countByName(one.getName())).isEqualTo(2);
403403
}
404404

405-
@Test // #945
405+
@Test // GH-945
406406
@EnabledOnFeature(TestDatabaseFeatures.Feature.IS_POSTGRES)
407407
public void usePrimitiveArrayAsArgument() {
408408
assertThat(repository.unnestPrimitive(new int[] { 1, 2, 3 })).containsExactly(1, 2, 3);
@@ -439,7 +439,7 @@ public void sliceByNameShouldReturnCorrectResult() {
439439
assertThat(slice.hasNext()).isTrue();
440440
}
441441

442-
@Test // #935
442+
@Test // GH-935
443443
public void queryByOffsetDateTime() {
444444

445445
Instant now = createDummyBeforeAndAfterNow();
@@ -450,7 +450,7 @@ public void queryByOffsetDateTime() {
450450
assertThat(entities).extracting(DummyEntity::getName).containsExactly("second");
451451
}
452452

453-
@Test // #971
453+
@Test // GH-971
454454
public void stringQueryProjectionShouldReturnProjectedEntities() {
455455

456456
repository.save(createDummyEntity());
@@ -461,7 +461,7 @@ public void stringQueryProjectionShouldReturnProjectedEntities() {
461461
assertThat(result.get(0).getName()).isEqualTo("Entity Name");
462462
}
463463

464-
@Test // #971
464+
@Test // GH-971
465465
public void stringQueryProjectionShouldReturnDtoProjectedEntities() {
466466

467467
repository.save(createDummyEntity());
@@ -472,7 +472,7 @@ public void stringQueryProjectionShouldReturnDtoProjectedEntities() {
472472
assertThat(result.get(0).getName()).isEqualTo("Entity Name");
473473
}
474474

475-
@Test // #971
475+
@Test // GH-971
476476
public void partTreeQueryProjectionShouldReturnProjectedEntities() {
477477

478478
repository.save(createDummyEntity());
@@ -483,7 +483,7 @@ public void partTreeQueryProjectionShouldReturnProjectedEntities() {
483483
assertThat(result.get(0).getName()).isEqualTo("Entity Name");
484484
}
485485

486-
@Test // #971
486+
@Test // GH-971
487487
public void pageQueryProjectionShouldReturnProjectedEntities() {
488488

489489
repository.save(createDummyEntity());
@@ -494,14 +494,14 @@ public void pageQueryProjectionShouldReturnProjectedEntities() {
494494
assertThat(result.getContent().get(0).getName()).isEqualTo("Entity Name");
495495
}
496496

497-
@Test // #974
497+
@Test // GH-974
498498
@EnabledOnFeature(TestDatabaseFeatures.Feature.IS_POSTGRES)
499499
void intervalCalculation() {
500500

501501
repository.updateWithIntervalCalculation(23L, LocalDateTime.now());
502502
}
503503

504-
@Test // #908
504+
@Test // GH-908
505505
void derivedQueryWithBooleanLiteralFindsCorrectValues() {
506506

507507
repository.save(createDummyEntity());

Diff for: ‎spring-data-jdbc/src/test/java/org/springframework/data/jdbc/repository/config/AbstractJdbcConfigurationIntegrationTests.java

+2-2
Original file line numberDiff line numberDiff line change
@@ -70,7 +70,7 @@ void configuresInfrastructureComponents() {
7070
}, AbstractJdbcConfigurationUnderTest.class, Infrastructure.class);
7171
}
7272

73-
@Test // #975
73+
@Test // GH-975
7474
void registersSimpleTypesFromCustomConversions() {
7575

7676
assertApplicationContext(context -> {
@@ -84,7 +84,7 @@ void registersSimpleTypesFromCustomConversions() {
8484
}, AbstractJdbcConfigurationUnderTest.class, Infrastructure.class);
8585
}
8686

87-
@Test // #908
87+
@Test // GH-908
8888
void userProvidedConversionsOverwriteDialectSpecificConversions() {
8989

9090
assertApplicationContext(applicationContext -> {

Diff for: ‎spring-data-jdbc/src/test/java/org/springframework/data/jdbc/repository/query/PartTreeJdbcQueryUnitTests.java

+1-1
Original file line numberDiff line numberDiff line change
@@ -117,7 +117,7 @@ public void createsQueryToFindAllEntitiesByStringAttribute() throws Exception {
117117
assertThat(query.getQuery()).isEqualTo(BASE_SELECT + " WHERE " + TABLE + ".\"FIRST_NAME\" = :first_name");
118118
}
119119

120-
@Test // #971
120+
@Test // GH-971
121121
public void createsQueryToFindAllEntitiesByProjectionAttribute() throws Exception {
122122

123123
when(returnedType.needsCustomConstruction()).thenReturn(true);

Diff for: ‎spring-data-relational/src/test/java/org/springframework/data/relational/core/sql/ConditionsUnitTests.java

+1-1
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,7 @@
2424
*/
2525
class ConditionsUnitTests {
2626

27-
@Test // #916
27+
@Test // GH-916
2828
void notInOfColumnAndExpression() {
2929

3030
Table table = Table.create("t");

Diff for: ‎spring-data-relational/src/test/java/org/springframework/data/relational/core/sql/render/ConditionRendererUnitTests.java

+2-2
Original file line numberDiff line numberDiff line change
@@ -233,7 +233,7 @@ public void shouldRenderNotIn() {
233233
assertThat(sql).endsWith("WHERE my_table.left NOT IN (my_table.right)");
234234
}
235235

236-
@Test // #907
236+
@Test // GH-907
237237
public void shouldRenderJust() {
238238

239239
String sql = SqlRenderer.toString(StatementBuilder.select(left).from(table)
@@ -243,7 +243,7 @@ public void shouldRenderJust() {
243243
assertThat(sql).endsWith("WHERE sql");
244244
}
245245

246-
@Test // #907
246+
@Test // GH-907
247247
public void shouldRenderMultipleJust() {
248248

249249
String sql = SqlRenderer.toString(StatementBuilder.select(left).from(table)

Diff for: ‎spring-data-relational/src/test/java/org/springframework/data/relational/repository/query/RelationalExampleMapperTests.java

+22-22
Original file line numberDiff line numberDiff line change
@@ -49,7 +49,7 @@ public void before() {
4949
exampleMapper = new RelationalExampleMapper(new RelationalMappingContext());
5050
}
5151

52-
@Test // #929
52+
@Test // GH-929
5353
void queryByExampleWithId() {
5454

5555
Person person = new Person();
@@ -64,7 +64,7 @@ void queryByExampleWithId() {
6464
.hasValue("(id = 'id1')");
6565
}
6666

67-
@Test // #929
67+
@Test // GH-929
6868
void queryByExampleWithFirstname() {
6969

7070
Person person = new Person();
@@ -79,7 +79,7 @@ void queryByExampleWithFirstname() {
7979
.hasValue("(firstname = 'Frodo')");
8080
}
8181

82-
@Test // #929
82+
@Test // GH-929
8383
void queryByExampleWithFirstnameAndLastname() {
8484

8585
Person person = new Person();
@@ -95,7 +95,7 @@ void queryByExampleWithFirstnameAndLastname() {
9595
.hasValue("(firstname = 'Frodo') AND (lastname = 'Baggins')");
9696
}
9797

98-
@Test // #929
98+
@Test // GH-929
9999
void queryByExampleWithNullMatchingLastName() {
100100

101101
Person person = new Person();
@@ -111,7 +111,7 @@ void queryByExampleWithNullMatchingLastName() {
111111
.hasValue("(lastname IS NULL OR lastname = 'Baggins')");
112112
}
113113

114-
@Test // #929
114+
@Test // GH-929
115115
void queryByExampleWithNullMatchingFirstnameAndLastname() {
116116

117117
Person person = new Person();
@@ -128,7 +128,7 @@ void queryByExampleWithNullMatchingFirstnameAndLastname() {
128128
.hasValue("(firstname IS NULL OR firstname = 'Bilbo') AND (lastname IS NULL OR lastname = 'Baggins')");
129129
}
130130

131-
@Test // #929
131+
@Test // GH-929
132132
void queryByExampleWithFirstnameAndLastnameIgnoringFirstname() {
133133

134134
Person person = new Person();
@@ -145,7 +145,7 @@ void queryByExampleWithFirstnameAndLastnameIgnoringFirstname() {
145145
.hasValue("(lastname = 'Baggins')");
146146
}
147147

148-
@Test // #929
148+
@Test // GH-929
149149
void queryByExampleWithFirstnameAndLastnameWithNullMatchingIgnoringFirstName() {
150150

151151
Person person = new Person();
@@ -162,7 +162,7 @@ void queryByExampleWithFirstnameAndLastnameWithNullMatchingIgnoringFirstName() {
162162
.hasValue("(lastname IS NULL OR lastname = 'Baggins')");
163163
}
164164

165-
@Test // #929
165+
@Test // GH-929
166166
void queryByExampleWithFirstnameWithStringMatchingAtTheBeginning() {
167167

168168
Person person = new Person();
@@ -178,7 +178,7 @@ void queryByExampleWithFirstnameWithStringMatchingAtTheBeginning() {
178178
.hasValue("(firstname LIKE 'Fro%')");
179179
}
180180

181-
@Test // #929
181+
@Test // GH-929
182182
void queryByExampleWithFirstnameWithStringMatchingOnTheEnding() {
183183

184184
Person person = new Person();
@@ -194,7 +194,7 @@ void queryByExampleWithFirstnameWithStringMatchingOnTheEnding() {
194194
.hasValue("(firstname LIKE '%do')");
195195
}
196196

197-
@Test // #929
197+
@Test // GH-929
198198
void queryByExampleWithFirstnameWithStringMatchingContaining() {
199199

200200
Person person = new Person();
@@ -210,7 +210,7 @@ void queryByExampleWithFirstnameWithStringMatchingContaining() {
210210
.hasValue("(firstname LIKE '%do%')");
211211
}
212212

213-
@Test // #929
213+
@Test // GH-929
214214
void queryByExampleWithFirstnameWithStringMatchingRegEx() {
215215

216216
Person person = new Person();
@@ -223,7 +223,7 @@ void queryByExampleWithFirstnameWithStringMatchingRegEx() {
223223
.withMessageContaining("REGEX is not supported!");
224224
}
225225

226-
@Test // #929
226+
@Test // GH-929
227227
void queryByExampleWithFirstnameWithFieldSpecificStringMatcherEndsWith() {
228228

229229
Person person = new Person();
@@ -239,7 +239,7 @@ void queryByExampleWithFirstnameWithFieldSpecificStringMatcherEndsWith() {
239239
.hasValue("(firstname LIKE '%do')");
240240
}
241241

242-
@Test // #929
242+
@Test // GH-929
243243
void queryByExampleWithFirstnameWithFieldSpecificStringMatcherStartsWith() {
244244

245245
Person person = new Person();
@@ -255,7 +255,7 @@ void queryByExampleWithFirstnameWithFieldSpecificStringMatcherStartsWith() {
255255
.hasValue("(firstname LIKE 'Fro%')");
256256
}
257257

258-
@Test // #929
258+
@Test // GH-929
259259
void queryByExampleWithFirstnameWithFieldSpecificStringMatcherContains() {
260260

261261
Person person = new Person();
@@ -271,7 +271,7 @@ void queryByExampleWithFirstnameWithFieldSpecificStringMatcherContains() {
271271
.hasValue("(firstname LIKE '%do%')");
272272
}
273273

274-
@Test // #929
274+
@Test // GH-929
275275
void queryByExampleWithFirstnameWithStringMatchingAtTheBeginningIncludingNull() {
276276

277277
Person person = new Person();
@@ -287,7 +287,7 @@ void queryByExampleWithFirstnameWithStringMatchingAtTheBeginningIncludingNull()
287287
.hasValue("(firstname IS NULL OR firstname LIKE 'Fro%')");
288288
}
289289

290-
@Test // #929
290+
@Test // GH-929
291291
void queryByExampleWithFirstnameWithStringMatchingOnTheEndingIncludingNull() {
292292

293293
Person person = new Person();
@@ -303,7 +303,7 @@ void queryByExampleWithFirstnameWithStringMatchingOnTheEndingIncludingNull() {
303303
.hasValue("(firstname IS NULL OR firstname LIKE '%do')");
304304
}
305305

306-
@Test // #929
306+
@Test // GH-929
307307
void queryByExampleWithFirstnameIgnoreCaseFieldLevel() {
308308

309309
Person person = new Person();
@@ -321,7 +321,7 @@ void queryByExampleWithFirstnameIgnoreCaseFieldLevel() {
321321
assertThat(example.getMatcher().getPropertySpecifiers().getForPath("firstname").getIgnoreCase()).isTrue();
322322
}
323323

324-
@Test // #929
324+
@Test // GH-929
325325
void queryByExampleWithFirstnameWithStringMatchingContainingIncludingNull() {
326326

327327
Person person = new Person();
@@ -337,7 +337,7 @@ void queryByExampleWithFirstnameWithStringMatchingContainingIncludingNull() {
337337
.hasValue("(firstname IS NULL OR firstname LIKE '%do%')");
338338
}
339339

340-
@Test // #929
340+
@Test // GH-929
341341
void queryByExampleWithFirstnameIgnoreCase() {
342342

343343
Person person = new Person();
@@ -355,7 +355,7 @@ void queryByExampleWithFirstnameIgnoreCase() {
355355
assertThat(example.getMatcher().isIgnoreCaseEnabled()).isTrue();
356356
}
357357

358-
@Test // #929
358+
@Test // GH-929
359359
void queryByExampleWithFirstnameOrLastname() {
360360

361361
Person person = new Person();
@@ -372,7 +372,7 @@ void queryByExampleWithFirstnameOrLastname() {
372372
.hasValue("(firstname = 'Frodo') OR (lastname = 'Baggins')");
373373
}
374374

375-
@Test // #929
375+
@Test // GH-929
376376
void queryByExampleEvenHandlesInvisibleFields() {
377377

378378
Person person = new Person();
@@ -388,7 +388,7 @@ void queryByExampleEvenHandlesInvisibleFields() {
388388
.hasValue("(firstname = 'Frodo') AND (secret = 'I have the ring!')");
389389
}
390390

391-
@Test // #929
391+
@Test // GH-929
392392
void queryByExampleSupportsPropertyTransforms() {
393393

394394
Person person = new Person();

0 commit comments

Comments
 (0)