Separate commonly used DepositionTypeCheck into methods

Closes gh-34573

Signed-off-by: ChanHyeongLee <[email protected]>
[[email protected]: apply code conventions]
Signed-off-by: Brian Clozel <[email protected]>

Author: Tussle0410

spring-web/src/main/java/org/springframework/http/ContentDisposition.java

@@ -99,23 +99,27 @@ private ContentDisposition(@Nullable String type, @Nullable String name, @Nullab
 	 * @since 5.3
 	 */
 	public boolean isAttachment() {
-		return (this.type != null && this.type.equalsIgnoreCase("attachment"));
+		return isDispositionType("attachment");
 	}
 
 	/**
 	 * Return whether the {@link #getType() type} is {@literal "form-data"}.
 	 * @since 5.3
 	 */
 	public boolean isFormData() {
-		return (this.type != null && this.type.equalsIgnoreCase("form-data"));
+		return isDispositionType("form-data");
 	}
 
 	/**
 	 * Return whether the {@link #getType() type} is {@literal "inline"}.
 	 * @since 5.3
 	 */
 	public boolean isInline() {
-		return (this.type != null && this.type.equalsIgnoreCase("inline"));
+		return isDispositionType("inline");
+	}
+
+	private boolean isDispositionType(String type) {
+		return this.type != null && this.type.equalsIgnoreCase(type);
 	}
 
 	/**
@@ -556,6 +560,7 @@ private static char hexDigit(int b) {
 	}
 
 
+
 	/**
 	 * A mutable builder for {@code ContentDisposition}.
 	 */

spring-web/src/test/java/org/springframework/http/ContentDispositionTests.java

@@ -310,4 +310,28 @@ void parseFormattedWithQuestionMark() {
 				.isEqualTo(filename);
 	}
 
+	@Test
+	void attachmentType(){
+		ContentDisposition attachment = ContentDisposition.attachment().build();
+		assertThat(attachment.isAttachment()).isTrue();
+		assertThat(attachment.isFormData()).isFalse();
+		assertThat(attachment.isInline()).isFalse();
+	}
+
+	@Test
+	void formDataType(){
+		ContentDisposition formData = ContentDisposition.formData().build();
+		assertThat(formData.isAttachment()).isFalse();
+		assertThat(formData.isFormData()).isTrue();
+		assertThat(formData.isInline()).isFalse();
+	}
+
+	@Test
+	void inlineType(){
+		ContentDisposition inline = ContentDisposition.inline().build();
+		assertThat(inline.isAttachment()).isFalse();
+		assertThat(inline.isFormData()).isFalse();
+		assertThat(inline.isInline()).isTrue();
+	}
+
 }