Skip to content

Commit 96895c7

Browse files
committed
Polishing in MethodArgumentNotValidException
See gh-30198
1 parent 96c494c commit 96895c7

File tree

1 file changed

+4
-15
lines changed

1 file changed

+4
-15
lines changed

Diff for: spring-web/src/main/java/org/springframework/web/bind/MethodArgumentNotValidException.java

+4-15
Original file line numberDiff line numberDiff line change
@@ -121,24 +121,13 @@ private static String join(List<String> errors) {
121121
* @return a Map with errors as keys and resolved messages as values
122122
* @since 6.0.3
123123
*/
124-
public Map<ObjectError, String> resolveErrorMessages(MessageSource messageSource, Locale locale) {
125-
Map<ObjectError, String> map = new LinkedHashMap<>();
126-
addMessages(map, getGlobalErrors(), messageSource, locale);
127-
addMessages(map, getFieldErrors(), messageSource, locale);
124+
public Map<ObjectError, String> resolveErrorMessages(MessageSource source, Locale locale) {
125+
Map<ObjectError, String> map = new LinkedHashMap<>(getErrorCount());
126+
getGlobalErrors().forEach(error -> map.put(error, formatError(error, source, locale)));
127+
getFieldErrors().forEach(error -> map.put(error, formatError(error, source, locale)));
128128
return map;
129129
}
130130

131-
private static void addMessages(
132-
Map<ObjectError, String> map, List<? extends ObjectError> errors,
133-
MessageSource messageSource, Locale locale) {
134-
135-
List<String> messages = errorsToStringList(errors, messageSource, locale);
136-
for (int i = 0; i < errors.size(); i++) {
137-
map.put(errors.get(i), messages.get(i));
138-
}
139-
}
140-
141-
142131
/**
143132
* Convert each given {@link ObjectError} to a String in single quotes, taking
144133
* either the error's default message, or its error code.

0 commit comments

Comments
 (0)