Skip to content

Commit dd4a347

Browse files
committed
Stop printing to System.out in SpEL tests
1 parent 46bd6ad commit dd4a347

File tree

3 files changed

+7
-6
lines changed

3 files changed

+7
-6
lines changed

spring-expression/src/test/java/org/springframework/expression/spel/AbstractExpressionTests.java

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -35,7 +35,7 @@
3535
*/
3636
public abstract class AbstractExpressionTests {
3737

38-
private static final boolean DEBUG = false;
38+
protected static final boolean DEBUG = false;
3939

4040
protected static final boolean SHOULD_BE_WRITABLE = true;
4141

@@ -202,7 +202,9 @@ protected void evaluateAndCheckError(String expression, Class<?> expectedReturnT
202202
protected void parseAndCheckError(String expression, SpelMessage expectedMessage, Object... otherProperties) {
203203
assertThatExceptionOfType(SpelParseException.class).isThrownBy(() -> {
204204
Expression expr = parser.parseExpression(expression);
205-
SpelUtilities.printAbstractSyntaxTree(System.out, expr);
205+
if (DEBUG) {
206+
SpelUtilities.printAbstractSyntaxTree(System.out, expr);
207+
}
206208
}).satisfies(ex -> {
207209
assertThat(ex.getMessageCode()).isEqualTo(expectedMessage);
208210
if (otherProperties != null && otherProperties.length != 0) {

spring-expression/src/test/java/org/springframework/expression/spel/EvaluationTests.java

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1450,7 +1450,9 @@ private void expectFailNotDecrementable(ExpressionParser parser, EvaluationConte
14501450
private void expectFail(ExpressionParser parser, EvaluationContext eContext, String expressionString, SpelMessage messageCode) {
14511451
assertThatExceptionOfType(SpelEvaluationException.class).isThrownBy(() -> {
14521452
Expression e = parser.parseExpression(expressionString);
1453-
SpelUtilities.printAbstractSyntaxTree(System.out, e);
1453+
if (DEBUG) {
1454+
SpelUtilities.printAbstractSyntaxTree(System.out, e);
1455+
}
14541456
e.getValue(eContext);
14551457
}).satisfies(ex -> assertThat(ex.getMessageCode()).isEqualTo(messageCode));
14561458
}

spring-expression/src/test/java/org/springframework/expression/spel/SpelReproTests.java

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1811,7 +1811,6 @@ else if (beanName.equals("goo")) {
18111811
static class CCC {
18121812

18131813
public boolean method(Object o) {
1814-
System.out.println(o);
18151814
return false;
18161815
}
18171816
}
@@ -1883,7 +1882,6 @@ static class Foo {
18831882
static class Foo2 {
18841883

18851884
public void execute(String str) {
1886-
System.out.println("Value: " + str);
18871885
}
18881886
}
18891887

@@ -1958,7 +1956,6 @@ public String process(String... args) {
19581956
public static class ReflectionUtil<T extends Number> {
19591957

19601958
public Object methodToCall(T param) {
1961-
System.out.println(param + " " + param.getClass());
19621959
return "Object methodToCall(T param)";
19631960
}
19641961

0 commit comments

Comments
 (0)