JoinPoint and Singature toString, toShortString, and toLongString don't return useful information [SPR-5437]

[spring-projects-issues]

Ramnivas Laddad opened SPR-5437 and commented

Furthermore, the method output doesn't match what AspectJ weaving produces making it difficult to migrate from/to Spring AOP and AspectJ weaving.

For example, here is what the current implementation of Spring AOP returns for these methods:

• JoinPoint.getSignature().toString() -- org.springframework.aop.aspectj.MethodInvocationProceedingJoinPoint$MethodSignatureImpl@1c737be
• JoinPoint.toString() -- org.springframework.aop.aspectj.MethodInvocationProceedingJoinPoint: execution(find)
• JoinPoint.getSignature().toShortString() -- find
• JoinPoint.toShortString() -- execution(find)
• JoinPoint.getSignature().toLongString() -- public abstract java.lang.Object com.myco.util.GenericRepository.find(java.lang.Long)
• JoinPoint.toLongString() -- org.springframework.aop.aspectj.MethodInvocationProceedingJoinPoint: execution:
  [ReflectiveMethodInvocation: public abstract java.lang.Object com.mycoutil.GenericRepository.find(java.lang.Long); target is of class [com.myco.repository.impl.JpaProductRepository]]

Basically, toString methods don't provide much useful information, short versions provide too little, and long versions provide too much :-) and not consistent in their output. As a result, these methods are not very useful for tracing, performance monitoring etc.

---

Referenced from: commits c8d6c15

[spring-projects-issues]

Ramnivas Laddad commented

Now the output matches that produced by the AspectJ weaver. Tests added to ensure that the two remain consistent.