Path variable doesn't handle periods correctly [SPR-16400]

[spring-projects-issues]

Michel Jung opened SPR-16400 and commented

Assume this controller:

@SpringBootApplication
@RestController
public class PathBugApplication {

	public static void main(String[] args) {
		SpringApplication.run(PathBugApplication.class, args);
	}

	@RequestMapping(path = "/{token}", method = RequestMethod.GET)
	public String bug(@PathVariable("token") String token) {
		return token;
	}
}

When calling http://localhost:8080/a.b.c, what is the expected output?

1. a.b.c
2. a.b

If 2. then everything is fine and I just need to RTFM (can you point me to it?)
If 1. then there's a bug, because the result is 2.

---

Affects: 4.3.13

[spring-projects-issues]

Brian Clozel commented

This is the expected behavior.
By default, Spring MVC enables suffix pattern matching - meaning that if you declare a "/something" pattern, this will also match automatically "/something.*". This is done to allow content negotiation using the file extension: "/something.json" will try to produce JSON, etc.

This is described in the reference documentation.

You can choose one of those solutions:

• use setUseSuffixPatternMatch(false) on the path matching configuration (see reference documentation)
• if you rely on suffix pattern matching in other places, you can alter your pattern to catch the extension, like "/{token:.+}"

Note that this default has been changed in Spring Boot 2.0.

[spring-projects-issues]

Michel Jung commented

Thank you very much for taking the time to explain it to me!