Skip to content

AbstractClientSockJsSession.close call does not propagate IOException from disconnect [SPR-16415] #20961

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
spring-projects-issues opened this issue Jan 25, 2018 · 0 comments
Closed

AbstractClientSockJsSession.close call does not propagate IOException from disconnect [SPR-16415] #20961

spring-projects-issues opened this issue Jan 25, 2018 · 0 comments
Assignees
@jhoeller
Labels
in: web Issues in web modules (web, webmvc, webflux, websocket) status: backported An issue that has been backported to maintenance branches type: bug A general bug
Milestone
5.0.4

Comments

@spring-projects-issues
Copy link
Collaborator

spring-projects-issues commented Jan 25, 2018 •
edited
Loading

Juergen Hoeller opened SPR-16415 and commented

AbstractClientSockJsSession.close and in particular AbstractClientSockJsSession.close(CloseReason) do not propagate an IOException from the disconnect attempt to the caller, despite the intention in their signature. While internal close attempts need to swallow and log such exceptions, explicit API calls should propagate them as expected.

Affects: 4.3.14, 5.0.3

Issue Links:

Backported to: 4.3.15
@spring-projects-issues spring-projects-issues added type: bug A general bug status: backported An issue that has been backported to maintenance branches in: web Issues in web modules (web, webmvc, webflux, websocket) labels Jan 11, 2019
@spring-projects-issues spring-projects-issues added this to the 5.0.4 milestone Jan 11, 2019
This was referenced Jan 11, 2019
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jhoeller jhoeller

Labels
in: web Issues in web modules (web, webmvc, webflux, websocket) status: backported An issue that has been backported to maintenance branches type: bug A general bug
Projects
None yet
Milestone
5.0.4
Development

No branches or pull requests
2 participants
@jhoeller @spring-projects-issues