Skip to content

PathPatternRouteMatcher should parse routes with custom separator #23167

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
bclozel opened this issue Jun 20, 2019 · 0 comments
Closed

PathPatternRouteMatcher should parse routes with custom separator #23167

bclozel opened this issue Jun 20, 2019 · 0 comments
Assignees
@bclozel
Labels
in: messaging Issues in messaging modules (jms, messaging) type: bug A general bug
Milestone
5.2 RC1

Comments

@bclozel
Copy link
Member

bclozel commented Jun 20, 2019

As of #23092, PathPatternParser allows custom separators.
PathPatternRouteMatcher accepts a PathPatternParser instance but does not use the configured separator when parsing routes from incoming requests.

This means that currently a Spring RSocket application configured with a . separator for pattern matching does not match correctly, since incoming routes are parsed with the / separator (which is the default).
@bclozel bclozel added in: messaging Issues in messaging modules (jms, messaging) type: bug A general bug labels Jun 20, 2019
@bclozel bclozel added this to the 5.2 RC1 milestone Jun 20, 2019
@bclozel bclozel self-assigned this Jun 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bclozel bclozel

Labels
in: messaging Issues in messaging modules (jms, messaging) type: bug A general bug
Projects
None yet
Milestone
5.2 RC1
Development

No branches or pull requests
1 participant
@bclozel