Skip to content

WebMvcConfigurationSupport.beanNameHandlerMapping does not set PathPatternParser #26414

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
philwebb opened this issue Jan 21, 2021 · 1 comment
Assignees
Labels
in: web Issues in web modules (web, webmvc, webflux, websocket) type: bug A general bug
Milestone

Comments

@philwebb
Copy link
Member

WebMvcConfigurationSupport.beanNameHandlerMapping creates a BeanNameUrlHandlerMapping instance but does not call setPatternParser.

Other mappings in the class have the following code:

PathPatternParser patternParser = getPathMatchConfigurer().getPatternParser();
if (patternParser != null) {
    mapping.setPatternParser(patternParser);
}
@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged or decided on label Jan 21, 2021
@rstoyanchev rstoyanchev self-assigned this Jan 22, 2021
@rstoyanchev
Copy link
Contributor

rstoyanchev commented Jan 22, 2021

The idea probably was that you don't need it for mappings based on bean names but it looks like patterns are supported.

@rstoyanchev rstoyanchev added in: web Issues in web modules (web, webmvc, webflux, websocket) type: bug A general bug and removed type: bug A general bug status: waiting-for-triage An issue we've not yet triaged or decided on labels Jan 22, 2021
@rstoyanchev rstoyanchev added this to the 5.3.4 milestone Jan 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
in: web Issues in web modules (web, webmvc, webflux, websocket) type: bug A general bug
Projects
None yet
Development

No branches or pull requests

3 participants