Skip to content

JdkHttpClientResourceFactory has dependency on org.eclipse.jetty #28588

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
j3graham opened this issue Jun 8, 2022 · 2 comments
Closed

JdkHttpClientResourceFactory has dependency on org.eclipse.jetty #28588

j3graham opened this issue Jun 8, 2022 · 2 comments
Assignees
@poutsma
Labels
in: web Issues in web modules (web, webmvc, webflux, websocket) type: bug A general bug
Milestone
6.0.0-M5

Comments

@j3graham
Copy link
Contributor

j3graham commented Jun 8, 2022 •
edited
Loading

in spring-web, org.springframework.http.client.reactive.JdkHttpClientResourceFactory makes use of the jetty LifeCycle class.

It would be good to be able to use JdkHttpClientResourceFactory with no extra dependencies.

This is in v 6.0
@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged or decided on label Jun 8, 2022
@j3graham j3graham closed this as not planned Won't fix, can't repro, duplicate, stale Jun 8, 2022
@j3graham j3graham reopened this Jun 8, 2022
@poutsma poutsma added this to the Triage Queue milestone Jun 13, 2022
@poutsma
Copy link
Contributor

poutsma commented Jun 13, 2022

@rstoyanchev was the usage of Jetty's LifeCycle type in JdkHttpClientResourceFactory intentional? I think it can be replaced with a check for ExecutorService in destroy(), and call ExecutorService::shutdown if so.

@rstoyanchev rstoyanchev added type: bug A general bug in: web Issues in web modules (web, webmvc, webflux, websocket) and removed status: waiting-for-triage An issue we've not yet triaged or decided on labels Jun 13, 2022
@rstoyanchev rstoyanchev modified the milestones: Triage Queue, 6.0.0-M5 Jun 13, 2022
@rstoyanchev
Copy link
Contributor

No, it's most certainly an oversight.

@poutsma poutsma self-assigned this Jun 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@poutsma poutsma

Labels
in: web Issues in web modules (web, webmvc, webflux, websocket) type: bug A general bug
Projects
None yet
Milestone
6.0.0-M5
Development

No branches or pull requests
4 participants
@poutsma @rstoyanchev @j3graham @spring-projects-issues