Skip to content

Add automatic hint for autowired field support #28655

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
snicoll opened this issue Jun 19, 2022 · 3 comments
Closed

Add automatic hint for autowired field support #28655

snicoll opened this issue Jun 19, 2022 · 3 comments
Assignees
@snicoll
Labels
theme: aot An issue related to Ahead-of-time processing type: regression A bug that is also a regression
Milestone
6.0.0-M5

Comments

@snicoll
Copy link
Member

snicoll commented Jun 19, 2022

If a field is flagged with @Autowired the container uses reflection to set the value. A hint should have been generated automatically for this but it looks like that's not the case at the moment.
@snicoll snicoll added type: enhancement A general enhancement theme: aot An issue related to Ahead-of-time processing labels Jun 19, 2022
@snicoll snicoll added this to the 6.0.0-M5 milestone Jun 19, 2022
@snicoll snicoll self-assigned this Jun 19, 2022
@snicoll
Copy link
Member Author

snicoll commented Jun 19, 2022

This is a regression of a refactoring. We used to flag a field regardless of its visibility and that is no longer the case.

@snicoll
Copy link
Member Author

snicoll commented Jun 19, 2022

A bit frustrating as the tests that were validating hints have been contributed have been dropped apparently.

@snicoll snicoll added type: regression A bug that is also a regression and removed type: enhancement A general enhancement labels Jun 19, 2022
@snicoll snicoll changed the title Add automatic hints for autowired support Add automatic hint for autowired field support Jun 19, 2022
@snicoll
Copy link
Member Author

snicoll commented Jun 20, 2022

Even more frustrating when I realize I was the one saying the hints was wrong in a review document 🙄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@snicoll snicoll

Labels
theme: aot An issue related to Ahead-of-time processing type: regression A bug that is also a regression
Projects
None yet
Milestone
6.0.0-M5
Development

No branches or pull requests
1 participant
@snicoll