Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ScriptFactoryPostProcessor#prepareScriptBeans is invoked twice and overrides bean definitions #32526

Closed
snicoll opened this issue Mar 25, 2024 · 1 comment
Closed

ScriptFactoryPostProcessor#prepareScriptBeans is invoked twice and overrides bean definitions #32526

snicoll opened this issue Mar 25, 2024 · 1 comment
Assignees
@snicoll
Labels
in: core Issues in core modules (aop, beans, core, context, expression) status: invalid An issue that we don't feel is valid type: task A general task

Comments

@snicoll
Copy link
Member

snicoll commented Mar 25, 2024 •
edited
Loading

In our efforts to get rid of bean overriding in the core framework, I've noticed that ScriptFactoryPostProcessor#prepareScriptBeans is invoked twice, that is:

  • From postProcessBeforeInstantiation which looks the regular call
  • And predictBeanType which looks a pre-init step to provide the right outcome

Ideally, this would only run once. Checking for the presence of scriptFactoryBeanName should be enough.
@snicoll snicoll added type: task A general task in: core Issues in core modules (aop, beans, core, context, expression) labels Mar 25, 2024
@snicoll snicoll modified the milestones: 6.1.x, 6.2.0-M1 Mar 25, 2024
@snicoll snicoll self-assigned this Mar 25, 2024
@snicoll
Copy link
Member Author

snicoll commented Mar 27, 2024

I don't know what happened with this one but I can't reproduce what I've described above.

@snicoll snicoll closed this as not planned Won't fix, can't repro, duplicate, stale Mar 27, 2024
@snicoll snicoll removed this from the 6.2.0-M1 milestone Mar 27, 2024
@snicoll snicoll added the status: invalid An issue that we don't feel is valid label Mar 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@snicoll snicoll

Labels
in: core Issues in core modules (aop, beans, core, context, expression) status: invalid An issue that we don't feel is valid type: task A general task
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@snicoll