Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BindingReflectionHintsRegistrar#registerReflectionHints can be invoked with a null type #32753

Closed
snicoll opened this issue May 2, 2024 · 1 comment
Closed

BindingReflectionHintsRegistrar#registerReflectionHints can be invoked with a null type #32753

snicoll opened this issue May 2, 2024 · 1 comment
Assignees
@snicoll
Labels
in: core Issues in core modules (aop, beans, core, context, expression) type: bug A general bug
Milestone
6.1.7

Comments

@snicoll
Copy link
Member

snicoll commented May 2, 2024

It currently states that the var arg types can be null, which should not happen. The signature should be revisited as well as its callers.
@snicoll snicoll added type: task A general task in: core Issues in core modules (aop, beans, core, context, expression) labels May 2, 2024
@snicoll snicoll added this to the 6.2.x milestone May 2, 2024
@snicoll snicoll changed the title Revisit nullability BindingReflectionHintsRegistrar#registerReflectionHints Revisit nullability of BindingReflectionHintsRegistrar#registerReflectionHints May 2, 2024
@snicoll snicoll self-assigned this May 2, 2024
@snicoll
Copy link
Member Author

snicoll commented May 2, 2024

It turns out that there are various places where we'd actually call the method with null, rather than not calling the registration if no type is available. This probably deserves to be fixed independently of the NullAway change.

@snicoll snicoll modified the milestones: 6.2.x, 6.1.7 May 2, 2024
@snicoll snicoll changed the title Revisit nullability of BindingReflectionHintsRegistrar#registerReflectionHints Revisit invocation of BindingReflectionHintsRegistrar#registerReflectionHints for null safety May 2, 2024
@snicoll snicoll changed the title Revisit invocation of BindingReflectionHintsRegistrar#registerReflectionHints for null safety BindingReflectionHintsRegistrar#registerReflectionHints can be invoked with a null type May 2, 2024
@snicoll snicoll added type: bug A general bug and removed type: task A general task labels May 2, 2024
@snicoll snicoll closed this as completed in abcc1df May 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@snicoll snicoll

Labels
in: core Issues in core modules (aop, beans, core, context, expression) type: bug A general bug
Projects
None yet
Milestone
6.1.7
Development

No branches or pull requests
1 participant
@snicoll